First draft of CODEOWNERS file #1082
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #1082 +/- ##
=======================================
Coverage 96.91% 96.91%
=======================================
Files 70 70
Lines 6929 6929
=======================================
Hits 6715 6715
Misses 214 214 Continue to review full report at Codecov.
|
namurphy
approved these changes
Mar 17, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Following #1080 and as discussed at yesterday's telecon, here's the next automationy/refactory/etc change from #1059.
The CODEOWNERS file automatically asks the people mentioned (@PlasmaPy/plasmapy-reviewers in general, @namurphy for Particles, @rocco8773 for Analysis/Diagnostics, @pheuer for proton radiography and myself for simulation in this first draft) for review on any newly opened, non-draft PR that modifies the files relevant files.
If you don't feel up to a review, you can just un-request yourself from the PR and someone else will always take over asap.
If any of you want to adjust the scope or opt out, I can of course do that for you, or you can modify the file yourself; the syntax is pretty simple.
I think if you turn a draft PR into a "full" PR, it still triggers in the same way.