Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Describe how to add example notebooks in the documentation guide #1381

Draft
wants to merge 15 commits into
base: main
Choose a base branch
from

Conversation

namurphy
Copy link
Member

@namurphy namurphy commented Jan 5, 2022

One thing I forgot to include in #1156 was how to add a Jupyter notebook to the examples page in the documentation. Since I'm adding a new notebook in #1380, I figured it was a good time to add documentation on how to do. I haven't added many notebooks, so I'll probably need some help on this one! At the very least, I can get it started.

Closes #1061. #1061 has some pretty useful information in it, so I'll need to read that again too.

@github-actions github-actions bot added the docs PlasmaPy Docs at http://docs.plasmapy.org label Jan 5, 2022
@namurphy
Copy link
Member Author

namurphy commented Jan 5, 2022

For the moment, I'm putting this directly in the documentation guide. If it gets long, it might be worth creating a separate page on how to add notebooks. To be decided later!

@namurphy namurphy marked this pull request as draft January 5, 2022 15:05
@codecov
Copy link

codecov bot commented Jan 5, 2022

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 95.18%. Comparing base (2a6cf7f) to head (e06b4d3).

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #1381   +/-   ##
=======================================
  Coverage   95.18%   95.18%           
=======================================
  Files         103      103           
  Lines        9412     9412           
  Branches     2153     2153           
=======================================
  Hits         8959     8959           
  Misses        276      276           
  Partials      177      177           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@@ -303,9 +303,9 @@ Markdown
A few of PlasmaPy's files are written using Markdown_, such as README
files and licenses from other packages. Markdown_ is simpler but more
limited than reST_. Markdown_ files use the file extension :file:`.md`.
Posts on GitHub are written in `GitHub Flavored Markdown`_. The
following code block contains a few common examples of Markdown_
formatting.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Which reminds me I've been meaning to mention https://myst-parser.readthedocs.io/en/latest/index.html ...

@namurphy
Copy link
Member Author

I just noticed that there was a section on this already in docs/development/code_guide.rst. In this PR, I think we could take that section, put it onto its own page, and then expand it. Having its own page would be helpful since that would make it easier to find, and would also reduce the scope of the documentation and code guides.

@namurphy
Copy link
Member Author

namurphy commented Jan 28, 2022

  • Add in a section on how to make colorblind friendly plots (viridis color table as suggested by @qudsiramiz, and colorblind friendly triplets like "#920000", "#006ddb", and "#db6d00")
  • Add link to coblis colorblind simulator

@qudsiramiz
Copy link
Member

FYI: Both 'Viridis" and "Cividis" are perceptually uniform and colorblind friendly, Cividis though also has the advantage of looking almost identical to both colorblind and non-colorblind users!

@namurphy
Copy link
Member Author

  • Describe how to add admonitions in notebooks, as described in this comment.

@namurphy namurphy added the status: on hold Issues & PRs that are being intentionally delayed label Mar 8, 2022
@namurphy
Copy link
Member Author

namurphy commented Mar 8, 2022

I'm putting this on hold for the moment, since what goes in here will depend on if we do end up deciding to switch from nbsphinx to myst_nb in #1474.

@namurphy namurphy added this to the 0.9.0 milestone Jun 28, 2022
@github-actions github-actions bot removed the docs PlasmaPy Docs at http://docs.plasmapy.org label Aug 20, 2022
@namurphy
Copy link
Member Author

  • Add a link to WebPlotDigitizer as a tool for extracting the underlying numerical data from a graphic of a plot. (Not sure if it should go in the coding guide, notebook guide, or testing guide since it could end up being helpful for a bunch of different reasons.)

@namurphy namurphy modified the milestones: 0.9.0, 0.10.0 Oct 27, 2022
@namurphy namurphy modified the milestones: 2023.1.0, 2023.9.0 Jan 9, 2023
@github-actions
Copy link

Thank you for contributing to PlasmaPy! The project's future depends deeply on contributors like you, so we deeply appreciate it! 🌱 The following checklist will be used by the code reviewer to help guide the code review process.

  • Overall
    • Does the PR do what it intends to do?
    • Except for very minor changes, is a changelog entry included and consistent with the changelog guide?
    • Are the continuous integration checks passing? (Most linter problems can be automagically fixed by commenting on this PR with pre-commit.ci autofix.)
  • Code
    • Is new/updated code understandable and consistent with the coding guide?
    • Are there ways to greatly simplify the implementation?
    • Are there any large functions that should be split up into shorter functions?
  • Tests
    • Are tests added/updated as required, and consistent with the testing guide?
    • Are the tests understandable?
    • Do the tests cover all important cases?
  • Docs
    • Are docs added/updated as required, and consistent with the doc guide?
    • Are the docs understandable?
    • Do the docs show up correctly in the preview, including Jupyter notebooks?

@namurphy namurphy added the status: dormant PRs that are stalled label May 26, 2023
@github-actions github-actions bot added the docs PlasmaPy Docs at http://docs.plasmapy.org label Aug 21, 2023
@namurphy namurphy modified the milestones: 2023.10.0, v2024.1.0 Oct 22, 2023
@namurphy namurphy removed this from the v2024.1.0 milestone Jan 17, 2024
@namurphy namurphy added this to the Future milestone Apr 9, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
contributor guide docs PlasmaPy Docs at http://docs.plasmapy.org status: dormant PRs that are stalled status: on hold Issues & PRs that are being intentionally delayed
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add notes on notebook to documentation links to doc dev guide
3 participants