Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add sections to coding guide on imports and requirements #1659

Merged
merged 14 commits into from Aug 15, 2022

Conversation

namurphy
Copy link
Member

@namurphy namurphy commented Aug 4, 2022

This is another spinoff of #1305 that describes guidelines related to imports and requirements.

When we are done with #1276, we should make sure to update the requirements section being added here.

@github-actions github-actions bot added the docs PlasmaPy Docs at http://docs.plasmapy.org label Aug 4, 2022
@codecov
Copy link

codecov bot commented Aug 4, 2022

Codecov Report

Merging #1659 (1588584) into main (94d2abb) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##             main    #1659   +/-   ##
=======================================
  Coverage   97.23%   97.23%           
=======================================
  Files          84       84           
  Lines        8016     8016           
=======================================
  Hits         7794     7794           
  Misses        222      222           

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@namurphy namurphy added the status: ready for review PRs that are ready for code review label Aug 4, 2022
@namurphy namurphy marked this pull request as ready for review August 11, 2022 21:04
@namurphy namurphy requested a review from a team August 15, 2022 14:39
Copy link
Member

@StanczakDominik StanczakDominik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍🏻

@namurphy namurphy merged commit f86bd58 into PlasmaPy:main Aug 15, 2022
@namurphy namurphy deleted the coding-guide-imports branch August 15, 2022 19:15
@namurphy namurphy removed the status: ready for review PRs that are ready for code review label Aug 15, 2022
@namurphy namurphy mentioned this pull request Aug 18, 2022
8 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
contributor guide docs PlasmaPy Docs at http://docs.plasmapy.org
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants