New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Rerun particle_tracing notebooks due to high resource usage #1933
Rerun particle_tracing notebooks due to high resource usage #1933
Conversation
Check out this pull request on See visual diffs & provide feedback on Jupyter Notebooks. Powered by ReviewNB |
Thank you for contributing to PlasmaPy! The project's future depends deeply on contributors like you, so we deeply appreciate it! 🌱 The following checklist will be used by the code reviewer to help guide the code review process.
|
Codecov ReportBase: 98.29% // Head: 98.31% // Increases project coverage by
Additional details and impacted files@@ Coverage Diff @@
## main #1933 +/- ##
==========================================
+ Coverage 98.29% 98.31% +0.01%
==========================================
Files 95 95
Lines 8409 8428 +19
==========================================
+ Hits 8266 8286 +20
+ Misses 143 142 -1
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report at Codecov. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Strange that they got un-pre-executed! In any case, LGTM, and thanks for doing this!
I haven't looked at the pdfs to tell how compatible they are with LaTeX, though that was a good point to bring up.
I think I forgot to re-execute them after the last PR that touched them, and that's that mystery solved 😅 |
I reran the particle tracing notebooks. Seems they somehow became un-pre-executed, and now they're slowing down the doc builds by a major factor. It's been causing intermittent doc build failures on main for a bit, now.
We might also have to disable the epub/pdf builds again because we might not actually be latex compatible - we'll see.