Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rerun particle_tracing notebooks due to high resource usage #1933

Merged

Conversation

StanczakDominik
Copy link
Member

I reran the particle tracing notebooks. Seems they somehow became un-pre-executed, and now they're slowing down the doc builds by a major factor. It's been causing intermittent doc build failures on main for a bit, now.

We might also have to disable the epub/pdf builds again because we might not actually be latex compatible - we'll see.

@StanczakDominik StanczakDominik requested a review from a team as a code owner January 25, 2023 17:10
@StanczakDominik StanczakDominik requested review from namurphy and removed request for a team January 25, 2023 17:10
@review-notebook-app
Copy link

Check out this pull request on  ReviewNB

See visual diffs & provide feedback on Jupyter Notebooks.


Powered by ReviewNB

@github-actions
Copy link

Thank you for contributing to PlasmaPy! The project's future depends deeply on contributors like you, so we deeply appreciate it! 🌱 The following checklist will be used by the code reviewer to help guide the code review process.

  • Overall
    • Does the PR do what it intends to do?
    • Except for very minor changes, is a changelog entry included and consistent with the changelog guide?
    • Are the continuous integration checks passing? (Most linter problems can be automagically fixed by commenting on this PR with pre-commit.ci autofix.)
  • Code
    • Is new/updated code understandable and consistent with the coding guide?
    • Are there ways to greatly simplify the implementation?
    • Are there any large functions that should be split up into shorter functions?
  • Tests
    • Are tests added/updated as required, and consistent with the testing guide?
    • Are the tests understandable?
    • Do the tests cover all important cases?
  • Docs
    • Are docs added/updated as required, and consistent with the doc guide?
    • Are the docs understandable?
    • Do the docs show up correctly in the preview, including Jupyter notebooks?

@codecov
Copy link

codecov bot commented Jan 25, 2023

Codecov Report

Base: 98.29% // Head: 98.31% // Increases project coverage by +0.01% 🎉

Coverage data is based on head (6b5c66c) compared to base (f433966).
Patch has no changes to coverable lines.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1933      +/-   ##
==========================================
+ Coverage   98.29%   98.31%   +0.01%     
==========================================
  Files          95       95              
  Lines        8409     8428      +19     
==========================================
+ Hits         8266     8286      +20     
+ Misses        143      142       -1     
Impacted Files Coverage Δ
plasmapy/particles/_factory.py 100.00% <0.00%> (ø)
plasmapy/particles/particle_class.py 98.72% <0.00%> (+0.16%) ⬆️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

Copy link
Member

@namurphy namurphy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Strange that they got un-pre-executed! In any case, LGTM, and thanks for doing this!

I haven't looked at the pdfs to tell how compatible they are with LaTeX, though that was a good point to bring up.

@StanczakDominik StanczakDominik merged commit 72406c6 into PlasmaPy:main Jan 25, 2023
@StanczakDominik StanczakDominik deleted the rerun_particle_radiography branch January 25, 2023 18:38
@StanczakDominik
Copy link
Member Author

I think I forgot to re-execute them after the last PR that touched them, and that's that mystery solved 😅

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants