New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Replace black
with ruff
in pre-commit config
#2394
Conversation
Fixes PlasmaPy#2393 Signed-off-by: Oscar <71343264+0scvr@users.noreply.github.com>
Thank you for submitting a pull request (PR) to PlasmaPy! ✨ The future of the project depends on contributors like you, so we deeply appreciate it! 🌱 Our contributor guide has information on:
The bottom of this page shows several checks that are run for every PR. Don't worry if something broke! We break stuff all the time. 😺 Click on "Details" to learn why a check didn't pass. Please also feel free to ask for help. We do that all the time as well. 🌸 You can find us in our chat room or weekly community meeting & office hours. Here are some tips:
If this PR is marked as ready for review, someone should stop by to provide a code review and offer suggestions soon. ✅ If you don't get a review within a few days, please feel free to send us a reminder. Please also use SI units within PlasmaPy, except when there is strong justification otherwise or in some examples. We thank you once again! |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #2394 +/- ##
=======================================
Coverage 96.91% 96.91%
=======================================
Files 104 104
Lines 9118 9118
=======================================
Hits 8837 8837
Misses 281 281 ☔ View full report in Codecov by Sentry. |
Signed-off-by: Oscar <71343264+0scvr@users.noreply.github.com>
Signed-off-by: Oscar <71343264+0scvr@users.noreply.github.com>
pre-commit.ci autofix |
for more information, see https://pre-commit.ci
I'm not sure why the docs fail to build. Should be working fine.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you for doing this! The doc build error is happening because we haven't connected our doc build to the docs for ruff or black, but I think my suggestion should be able to fix it. Thank you again for addressing this so quickly!
Co-authored-by: Nick Murphy <namurphy@cfa.harvard.edu>
pre-commit.ci autofix |
for more information, see https://pre-commit.ci
Description
Replaced
black
withruff
in pre-commit configMotivation and context
Related issues
Fixes #2393