Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add mypy configuration file that ignores existing errors on a per-file and per-error basis #2424

Merged
merged 33 commits into from
Dec 29, 2023
Merged

Add mypy configuration file that ignores existing errors on a per-file and per-error basis #2424

merged 33 commits into from
Dec 29, 2023

Commits on Dec 21, 2023

  1. Add permissive mypy configuration

    @namurphy
    namurphy committed Dec 21, 2023
    Configuration menu
    Copy the full SHA
    d4907fb View commit details
    Browse the repository at this point in the history

  2. Add mypy to pre-commit

    @namurphy
    namurphy committed Dec 21, 2023
    Configuration menu
    Copy the full SHA
    817140d View commit details
    Browse the repository at this point in the history

  3. Remove mypy section in pyproject.toml

    @namurphy
    namurphy committed Dec 21, 2023
    Configuration menu
    Copy the full SHA
    0e239d8 View commit details
    Browse the repository at this point in the history

  4. Add mypy.ini 

    Setting up the mypy configuration in pyproject.toml was giving me a headache
when I was trying out how to exclude files.
    @namurphy
    namurphy committed Dec 21, 2023
    Configuration menu
    Copy the full SHA
    affee6a View commit details
    Browse the repository at this point in the history

  5. Remove type syntax causing an error

    @namurphy
    namurphy committed Dec 21, 2023
    Configuration menu
    Copy the full SHA
    4eb64b6 View commit details
    Browse the repository at this point in the history

  6. Skip directories when running mypy with pre-commit

    @namurphy
    namurphy committed Dec 21, 2023
    Configuration menu
    Copy the full SHA
    5794d63 View commit details
    Browse the repository at this point in the history

  7. Be more specific about type: ignore

    @namurphy
    namurphy committed Dec 21, 2023
    Configuration menu
    Copy the full SHA
    231a98c View commit details
    Browse the repository at this point in the history

  8. Add changelog entry

    @namurphy
    namurphy committed Dec 21, 2023
    Configuration menu
    Copy the full SHA
    87008ed View commit details
    Browse the repository at this point in the history

Commits on Dec 28, 2023

  1. Merge branch 'main' of github.com:PlasmaPy/PlasmaPy into enable-mypy

    @namurphy
    namurphy committed Dec 28, 2023
    Configuration menu
    Copy the full SHA
    5b7b406 View commit details
    Browse the repository at this point in the history

  2. Update mypy.ini following change to Quantity annotations

    @namurphy
    namurphy committed Dec 28, 2023
    Configuration menu
    Copy the full SHA
    647df4b View commit details
    Browse the repository at this point in the history

  3. Use pretty output for mypy

    @namurphy
    namurphy committed Dec 28, 2023
    Configuration menu
    Copy the full SHA
    dccac87 View commit details
    Browse the repository at this point in the history

  4. Add type hints for empty __all__s'

    @namurphy
    namurphy committed Dec 28, 2023
    Configuration menu
    Copy the full SHA
    4edda60 View commit details
    Browse the repository at this point in the history

  5. Update global settings for mypy

    @namurphy
    namurphy committed Dec 28, 2023
    Configuration menu
    Copy the full SHA
    9cc0646 View commit details
    Browse the repository at this point in the history

Commits on Dec 29, 2023

  1. Typing fix in plasmapy/__init__.py

    @namurphy
    namurphy committed Dec 29, 2023
    Configuration menu
    Copy the full SHA
    1ed4ea8 View commit details
    Browse the repository at this point in the history

  2. Add Quantity type hint annotations

    @namurphy
    namurphy committed Dec 29, 2023
    Configuration menu
    Copy the full SHA
    f159a06 View commit details
    Browse the repository at this point in the history

  3. Add typing stub packages for pandas, requests, & tqdm

    @namurphy
    namurphy committed Dec 29, 2023
    Configuration menu
    Copy the full SHA
    62f45df View commit details
    Browse the repository at this point in the history

  4. Enable quasi-strict mypy setting 

    ...noting that all current violations of these rules will be ignored.
    @namurphy
    namurphy committed Dec 29, 2023
    Configuration menu
    Copy the full SHA
    9683647 View commit details
    Browse the repository at this point in the history

  5. Raise errors if there are type warnings w/o codes

    @namurphy
    namurphy committed Dec 29, 2023
    Configuration menu
    Copy the full SHA
    a3f040b View commit details
    Browse the repository at this point in the history

  6. Ignore specific typing errors for different subpackages

    @namurphy
    namurphy committed Dec 29, 2023
    Configuration menu
    Copy the full SHA
    a030df8 View commit details
    Browse the repository at this point in the history

  7. Temporarily add script to create mypy.ini sections

    @namurphy
    namurphy committed Dec 29, 2023
    Configuration menu
    Copy the full SHA
    6739b65 View commit details
    Browse the repository at this point in the history

  8. Remove script to add mypy sections

    @namurphy
    namurphy committed Dec 29, 2023
    Configuration menu
    Copy the full SHA
    b03c922 View commit details
    Browse the repository at this point in the history

  9. Update errors to ignore with newer version of mypy

    @namurphy
    namurphy committed Dec 29, 2023
    Configuration menu
    Copy the full SHA
    9112260 View commit details
    Browse the repository at this point in the history

  10. Update 2424.trivial.rst

    @namurphy
    namurphy committed Dec 29, 2023
    Configuration menu
    Copy the full SHA
    a42c8b3 View commit details
    Browse the repository at this point in the history

  11. Put back the backtick

    @namurphy
    namurphy committed Dec 29, 2023
    Configuration menu
    Copy the full SHA
    b70cda4 View commit details
    Browse the repository at this point in the history

  12. Regenerate requirements file

    @namurphy
    namurphy committed Dec 29, 2023
    Configuration menu
    Copy the full SHA
    6ae4501 View commit details
    Browse the repository at this point in the history

  13. Add error code to ignore

    @namurphy
    namurphy committed Dec 29, 2023
    Configuration menu
    Copy the full SHA
    ea8740c View commit details
    Browse the repository at this point in the history

  14. Merge branch 'enable-mypy' of github.com:namurphy/PlasmaPy into enabl… 

    …e-mypy
    @namurphy
    namurphy committed Dec 29, 2023
    Configuration menu
    Copy the full SHA
    9b81a53 View commit details
    Browse the repository at this point in the history

  15. Add more per-file mypy error codes to ignore 

    Strangely, I was getting different results from mypy using a pre-commit hook
vs running it locally. I think it's probably due to running different versio
of mypy.
    @namurphy
    namurphy committed Dec 29, 2023
    Configuration menu
    Copy the full SHA
    badc705 View commit details
    Browse the repository at this point in the history

  16. Add final missing error code

    @namurphy
    namurphy committed Dec 29, 2023
    Configuration menu
    Copy the full SHA
    96122db View commit details
    Browse the repository at this point in the history

  17. Update comment

    @namurphy
    namurphy committed Dec 29, 2023
    Configuration menu
    Copy the full SHA
    1b5b780 View commit details
    Browse the repository at this point in the history

  18. Add comments about mypy type stubs packages

    @namurphy
    namurphy committed Dec 29, 2023
    Configuration menu
    Copy the full SHA
    d263bbf View commit details
    Browse the repository at this point in the history

  19. Remove mypy from pre-commit

    @namurphy
    namurphy committed Dec 29, 2023
    Configuration menu
    Copy the full SHA
    a3bcf0c View commit details
    Browse the repository at this point in the history

  20. Merge branch 'main' of github.com:PlasmaPy/PlasmaPy into enable-mypy

    @namurphy
    namurphy committed Dec 29, 2023
    Configuration menu
    Copy the full SHA
    9295e10 View commit details
    Browse the repository at this point in the history