New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ci: run hyperlink checking with quiet mode flag enabled #2476
Conversation
This is intended to make it easier to find and fix broken links; in quiet mode, the linkcheck builder suppresses much of its reporting to stdout, including successful (ok) check results -- and so what appears in GitHub Actions console, for example, with the quiet flag in place should be more concise and actionable.
Thank you for submitting a pull request (PR) to PlasmaPy! ✨ The future of the project depends on contributors like you, so we deeply appreciate it! 🌱 Our contributor guide has information on:
The bottom of this page shows several checks that are run for every PR. Don't worry if something broke! We break stuff all the time. 😺 Click on "Details" to learn why a check didn't pass. Please also feel free to ask for help. We do that all the time as well. 🌸 You can find us in our chat room or weekly community meeting & office hours. Here are some tips:
If this PR is marked as ready for review, someone should stop by to provide a code review and offer suggestions soon. ✅ If you don't get a review within a few days, please feel free to send us a reminder. Please also use SI units within PlasmaPy, except when there is strong justification otherwise or in some examples. We thank you once again! |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #2476 +/- ##
=======================================
Coverage 96.93% 96.93%
=======================================
Files 104 104
Lines 9163 9163
=======================================
Hits 8882 8882
Misses 281 281 ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is fantastic! Thank you once again!
You're welcome @namurphy - it's a good way for me to learn a bit more about how the |
Description
The Sphinx linkcheck builder supports a
-q / --quiet
flag that reduces output verbosity while continuing to output warnings and errors.This change enables the flag for the scheduled
Check hyperlinks
GitHub Actions worklow.Motivation and context
For projects like this one that feature large numbers of healthy hyperlinks, the default linkchecker output to stdout can be overly verbose, with broken/problem hyperlink reports interspersed among many reports of healthy links, making it hard to collect and find the set of problems to fix.
Note
The
linkcheck
builder emits a warning when it encounters an HTTP redirect that doesn't match an entry within thelinkcheck_allowed_redirects
patterns -PlasmaPy
has a few of these at the moment - mostly related to GitHub users. Although allowing valid redirects is generally good practice, it is possible to ignore (skip) checking for link patterns by usinglinkcheck_ignore
if necessary.Related issues
N/A