Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Parametrize tests of Debye_length #2509

Merged
merged 12 commits into from Mar 4, 2024
Merged

Conversation

namurphy
Copy link
Member

@namurphy namurphy commented Feb 8, 2024

PlasmaPy's tests of Debye_length are currently consolidated into a single test function with multiple assert statements. This PR changes the test setup to use @pytest.mark.parametrize.

I've been meaning to get to this for a couple of years, but better late than never!

@github-actions github-actions bot added plasmapy.formulary Related to the plasmapy.formulary subpackage testing labels Feb 8, 2024
Copy link

codecov bot commented Feb 13, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 97.36%. Comparing base (20e60aa) to head (17df492).
Report is 56 commits behind head on main.

❗ Current head 17df492 differs from pull request most recent head 64c2b5f. Consider uploading reports for the commit 64c2b5f to get more accurate results

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #2509      +/-   ##
==========================================
+ Coverage   96.93%   97.36%   +0.43%     
==========================================
  Files         104      104              
  Lines        9163     9375     +212     
==========================================
+ Hits         8882     9128     +246     
+ Misses        281      247      -34     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@github-actions github-actions bot added the plasmapy.simulation Related to the plasmapy.simulation subpackage label Feb 13, 2024
@namurphy namurphy marked this pull request as ready for review March 4, 2024 20:42
@namurphy namurphy requested a review from a team as a code owner March 4, 2024 20:42
@namurphy namurphy requested review from ejohnson-96 and removed request for a team March 4, 2024 20:42
Copy link
Contributor

@ejohnson-96 ejohnson-96 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@namurphy namurphy merged commit fdb73d2 into PlasmaPy:main Mar 4, 2024
15 checks passed
@namurphy namurphy deleted the test-debye-length branch March 4, 2024 22:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
plasmapy.formulary Related to the plasmapy.formulary subpackage plasmapy.simulation Related to the plasmapy.simulation subpackage testing
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants