New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add examples to thermal_bremsstrahlung
docstring
#2618
Conversation
Thank you for submitting a pull request (PR) to PlasmaPy! ✨ The future of the project depends on contributors like you, so we deeply appreciate it! 🌱 Our contributor guide has information on:
The bottom of this page shows several checks that are run for every PR. Don't worry if something broke! We break stuff all the time. 😺 Click on "Details" to learn why a check didn't pass. Please also feel free to ask for help. We do that all the time as well. 🌸 You can find us in our chat room or weekly community meeting & office hours. Here are some tips:
If this PR is marked as ready for review, someone should stop by to provide a code review and offer suggestions soon. ✅ If you don't get a review within a few days, please feel free to send us a reminder. Please also use SI units within PlasmaPy, except when there is strong justification otherwise or in some examples. We thank you once again! |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #2618 +/- ##
=======================================
Coverage 95.17% 95.17%
=======================================
Files 104 104
Lines 9417 9417
Branches 2154 2154
=======================================
Hits 8963 8963
Misses 276 276
Partials 178 178 ☔ View full report in Codecov by Sentry. |
Not sure I understand the Read the Docs error in the checks. What have I done wrong here? |
@namurphy FYI Edit: opened #2620 This isn't related to this PR, so @namurphy I suggest we ignore the error? |
Well, at least glad to hear it wasn't something I did. I was a bit surprised that adding comments should cause issues. Thanks for diagnosing the error! |
Thanks for finding it! A fix has now been merged into main, so if you merge main into this branch this test should pass! |
Well, readthedocs passed, but looks like another bug has taken its place. Has anything else been patched?
|
This test that failed relies on a connection to the GitHub API, and for some reason it looks like that is timing out? I wonder if the API is just temporarily down? I am trying re-running it
|
Ok, re-running that test fixed it, so I think it was just a communication issue with the API @namurphy it looks like the codecov error is rearing it's head again, even after I think #2624 was merged into this branch?
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM! 👍🏻 Thank you again for doing this, and for your patience while we fixed some of our continuous integration checks! Happy to merge it now that we got the stuff that broke figured out.
Description
I've added a few examples to the docstring of
thermal_bremsstrahlung
.Related issues
Fixes #2529