Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Discuss consequences of switch to src layout in README.md #2633

Merged
merged 5 commits into from
Apr 14, 2024

Conversation

namurphy
Copy link
Member

Following up on #2598, this PR adds some notes to README.md that describe what contributors need to know to update to the new src layout.

I'll also expand the information in the comment that gets posted to new PRs.

@github-actions github-actions bot added the docs PlasmaPy Docs at http://docs.plasmapy.org label Apr 12, 2024
@pheuer
Copy link
Member

pheuer commented Apr 12, 2024

Copy link

codecov bot commented Apr 12, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 95.18%. Comparing base (2a6cf7f) to head (53bf080).

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #2633   +/-   ##
=======================================
  Coverage   95.18%   95.18%           
=======================================
  Files         103      103           
  Lines        9412     9412           
  Branches     2153     2153           
=======================================
  Hits         8959     8959           
  Misses        276      276           
  Partials      177      177           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@github-actions github-actions bot added the GitHub Actions A continuous integration platform for automating tests and other tasks (see .github/ directory) label Apr 12, 2024
@namurphy
Copy link
Member Author

Apparently you can also do announcement banners for organizations?

Holy hopping rutabagas! I did not know that! I'll try it out.

@namurphy
Copy link
Member Author

Alas, it turns out that you have to have an enterprise GitHub account to be able to do the organization-wide announcements...

@namurphy namurphy marked this pull request as ready for review April 12, 2024 21:29
@namurphy namurphy requested a review from a team as a code owner April 12, 2024 21:29
@namurphy namurphy requested review from ejohnson-96 and removed request for a team April 12, 2024 21:29
README.md Outdated Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
Copy link
Contributor

@ejohnson-96 ejohnson-96 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@namurphy namurphy merged commit 877a063 into PlasmaPy:main Apr 14, 2024
16 checks passed
@namurphy namurphy deleted the src-followup branch April 14, 2024 00:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
docs PlasmaPy Docs at http://docs.plasmapy.org GitHub Actions A continuous integration platform for automating tests and other tasks (see .github/ directory) no changelog entry needed
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants