Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove upper limit on Sphinx #2646

Merged
merged 2 commits into from
Apr 22, 2024
Merged

Remove upper limit on Sphinx #2646

merged 2 commits into from
Apr 22, 2024

Conversation

namurphy
Copy link
Member

@namurphy namurphy commented Apr 22, 2024

In #2497, we described an error that was occurring in the dev version of Sphinx, so we preemptively pinned sphinx == 7.2.6. There were a few Sphinx 7.3.* releases in the last week or two, so this PR removes the strict requirement. And the documentation build is passing, so yay! 🎆

@github-actions github-actions bot added requirements Related to updating requirements packaging Related to packaging or distribution labels Apr 22, 2024
Copy link

codecov bot commented Apr 22, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 95.22%. Comparing base (07ac1f1) to head (f0d602d).

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #2646   +/-   ##
=======================================
  Coverage   95.22%   95.22%           
=======================================
  Files         103      103           
  Lines        9401     9401           
  Branches     2151     2151           
=======================================
  Hits         8952     8952           
  Misses        274      274           
  Partials      175      175           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@namurphy namurphy marked this pull request as ready for review April 22, 2024 23:35
@namurphy namurphy requested a review from a team as a code owner April 22, 2024 23:35
@namurphy namurphy requested review from ejohnson-96 and removed request for a team April 22, 2024 23:35
@namurphy namurphy merged commit 31d15be into PlasmaPy:main Apr 22, 2024
21 checks passed
@namurphy namurphy deleted the sphinx-7.3.7 branch April 22, 2024 23:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
no changelog entry needed packaging Related to packaging or distribution requirements Related to updating requirements
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant