Update Codecov settings #2653
Merged
Update Codecov settings #2653
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
docs
namurphy
commented
Apr 30, 2024
| @@ -4,15 +4,13 @@ codecov: | |||
| wait_for_ci: false | |||
| require_ci_to_pass: false | |||
| coverage: | |||
| range: 75..98 | |||
| range: 90..98 | |||
There was a problem hiding this comment.
The range here defines for Codecov reports when the value should appear as red (below 90%), yellow (between 90% to 98%), or green (98% to 100%).
|
I think I need to merge this before we can tell if it is working or not. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We've been having some problems with our Codecov configuration the last few months. This PR makes it so that CI can pass if the Codecov report doesn't upload correctly. I've correspondingly set it so that the codecov/patch check is now required, so it's more apparent if it is missing. This is a bandaid 馃┕ which we'll have to look into further.