-
Notifications
You must be signed in to change notification settings - Fork 335
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Find our missing coverage #495
Comments
Geez I do bad issue names in a hurry. @ritiek this is what I just realized you were tinkering with in matrix! It should solve the pragma issue. |
Actually I'm probably wrong in that first guess. The tool we need to point at coveragerc is coveragepy itself, so we probably need to grep sunpy files for references to coveragerc and fill in any missing ones. |
Couldn't we just move |
I thought there was something in setup.py test that broke when I did that... I'm not sure. I'll check later. |
Based on this:
https://codecov.io/gh/PlasmaPy/PlasmaPy/src/master/plasmapy/_base_init.py
And this:
https://codecov.io/gh/PlasmaPy/PlasmaPy/src/master/plasmapy/diagnostics/langmuir.py#L1220
I don't think Codecov sees this:
https://github.com/PlasmaPy/PlasmaPy/blob/master/plasmapy/tests/coveragerc#L10
so we might need a yaml in the base directory of the repo to point Codecov to the coveragerc file somehow. We might also need to compare with this https://github.com/sunpy/sunpy/blob/master/sunpy/tests/coveragerc
The text was updated successfully, but these errors were encountered: