Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Find our missing coverage #495

Closed
StanczakDominik opened this issue Jun 12, 2018 · 4 comments
Closed

Find our missing coverage #495

StanczakDominik opened this issue Jun 12, 2018 · 4 comments
Labels

Comments

@StanczakDominik
Copy link
Member

Based on this:

https://codecov.io/gh/PlasmaPy/PlasmaPy/src/master/plasmapy/_base_init.py

And this:

https://codecov.io/gh/PlasmaPy/PlasmaPy/src/master/plasmapy/diagnostics/langmuir.py#L1220

I don't think Codecov sees this:

https://github.com/PlasmaPy/PlasmaPy/blob/master/plasmapy/tests/coveragerc#L10

so we might need a yaml in the base directory of the repo to point Codecov to the coveragerc file somehow. We might also need to compare with this https://github.com/sunpy/sunpy/blob/master/sunpy/tests/coveragerc

@StanczakDominik StanczakDominik added effort: minimal Requiring perhaps tens of minutes help wanted Unassigned issues that would benefit from assistance or contributions needed from the community testing labels Jun 12, 2018
@StanczakDominik
Copy link
Member Author

Geez I do bad issue names in a hurry. @ritiek this is what I just realized you were tinkering with in matrix! It should solve the pragma issue.

@StanczakDominik
Copy link
Member Author

Actually I'm probably wrong in that first guess. The tool we need to point at coveragerc is coveragepy itself, so we probably need to grep sunpy files for references to coveragerc and fill in any missing ones.

@StanczakDominik StanczakDominik changed the title Add yaml to repo Find our missing coverage Jun 12, 2018
@ritiek
Copy link
Contributor

ritiek commented Jun 12, 2018

Couldn't we just move PlasmaPy/plasmapy/tests/coveragerc to plasmapy's root directory (PlasmaPy/.coveragerc with a dot)? That should fix things I believe.

@StanczakDominik
Copy link
Member Author

I thought there was something in setup.py test that broke when I did that... I'm not sure. I'll check later.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

3 participants