[PROTO] Langmuir Diagnostic & the Diagnostic Framework #813
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…oating_potential.py with the find_floating_potential() function
…s.core; define class plasmapy.diagnostics.core.XDiagnostics which replaces the PlasmaPyAccessor class; create module attribute plasmapy.diagnostics.xdiagnostics which is an instance of XDiagnostics
…or if already register to xarray.Dataset
|
Rated 8 out of transport This does not look like something I couldn't review, at a glance. For the record I'm fine with hosting a feature branch for it. I worry about merging difficulty a little, but let's try it. |
…g-point array due to index wrapping when array is shifted
…rning about padding
|
Hello @rocco8773! Thanks for updating your pull request.
|
…c specific xarray `sel` method
# Conflicts: # plasmapy/diagnostics/__init__.py
namurphy
added
the
plasmapy.diagnostics
rocco8773
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Not official...just to see the beginnings of this prototype