Adding function find_plasma_potential_dI/dV #897

gkbal · 2020-09-14T18:36:21Z

Should be merged after PR #889
Adding in function find_plasma_potential_dI/dV

I have added a changelog entry for this pull request.

If adding new functionality, I have added tests and
docstrings.

I have fixed any newly failing tests.

…initial commit for /docs/ad/index.rst

…tics/; add attention admonition to index.rst

…ics"

…oating_potential.py with the find_floating_potential() function

…space

…_potential.rst

Co-authored-by: Dominik Stańczak <stanczakdominik@gmail.com>

…namespace

…entally included

…dices respectively

…and indices and add to meta_dict

…ent retislands and refit; add check for monotonic voltage array

…eckpoints"

…functions

…r returning values; eliminate kwargs retfit and retislands; add kwarg fit_type; update behavior of min_points to all for all points, specified number of points, or a fraction of the array size

# Conflicts: # plasmapy/analysis/swept_langmuir/floating_potential.py

…to test that

…ved it from it's previous notebook

# Conflicts: # plasmapy/analysis/swept_langmuir/__init__.py

…add module level docstrings; add imports; add __all__

…update doc for plasmapy.analysis.swept_langmuir

codecov · 2020-09-14T19:16:02Z

Codecov Report

Merging #897 into master will decrease coverage by 2.57%.
The diff coverage is 35.68%.

@@            Coverage Diff             @@
##           master     #897      +/-   ##
==========================================
- Coverage   96.21%   93.63%   -2.58%     
==========================================
  Files          60       65       +5     
  Lines        5414     5655     +241     
==========================================
+ Hits         5209     5295      +86     
- Misses        205      360     +155

Impacted Files	Coverage Δ
...mapy/analysis/swept_langmuir/floating_potential.py	`8.60% <8.60%> (ø)`
...asmapy/analysis/swept_langmuir/plasma_potential.py	`20.00% <20.00%> (ø)`
plasmapy/analysis/swept_langmuir/fit_functions.py	`48.07% <48.07%> (ø)`
plasmapy/analysis/__init__.py	`100.00% <100.00%> (ø)`
plasmapy/analysis/swept_langmuir/__init__.py	`100.00% <100.00%> (ø)`
plasmapy/diagnostics/langmuir.py	`93.75% <100.00%> (+0.53%)`	⬆️
... and 1 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 8e108d9...132203e. Read the comment docs.

rocco8773 and others added 30 commits July 31, 2020 09:55

create the plasmapy.analysis sub-package

e00fa48

create the "Analyses & Diagnostics" documenation folder (/docs/ad/); …

940b9fc

…initial commit for /docs/ad/index.rst

move the diagnostics doc files /docs/diagnostics/ -> /docs/ad/diagnos…

23229d2

…tics/; add attention admonition to index.rst

replace "Diagnostics" sidebar toctree entry with "Analyses & Diagnost…

efce2a1

…ics"

initial commit for /docs/ad/analysis/

c709168

add basic docstring to plasmapy/analysis/__init__.py

4cb96c3

create the plasmapy.diagnostics.swept_langmuir sub-package

a13250e

create the plasmapy.analysis.swept_langmuir sub-package and define fl…

023b763

…oating_potential.py with the find_floating_potential() function

change from attention to important admonition

1402b1f

expose plasmapy.analysis.swept_langmuir to the plasmapy.analysis name…

af979dc

…space

add ad admonition and an additional warning admonition

e8b0e21

create /docs/ad/analysis/swept_langmuir.rst page

35e07ad

create api_static stub file plasmapy.analysis.swept_langmuir.floating…

d69bad6

…_potential.rst

add swept langmuir doc pages to /docs/ad/analysis/index.rst

4bd4fb2

fix typos

f0f8c10

Co-authored-by: Dominik Stańczak <stanczakdominik@gmail.com>

Merge branch 'master_from_plasmapy' into ad-lang-vf

7c3cb25

Merge branch 'master_from_plasmapy' into ad-lang-vf

6254775

expose find_floating_potential to plasmapy.analysis.swept_langmuir …

bf7f520

…namespace

fix spelling mistakes

c233b15

repair generation of cp_candidates s.t. array endpoints are not accid…

b003da9

…entally included

add kwargs retfit and retislands for returning fit info and island in…

0f8c227

…dices respectively

introduce meta_dict for island and fit info; update collection of isl…

6474162

…and indices and add to meta_dict

repair padding of crossing island s.t. points are actually added to it

cdf7f6d

add fit info to meta_dict; cleanup definition of vf_err; fully implem…

2c166ea

…ent retislands and refit; add check for monotonic voltage array

add a notebook for adding noise to one of the smooth langmuir samples

cff5bc4

create a noisy Beckers2017.npy (Beckers2017_noisy.npy)

44faa1e

initial commit for plasmapy.analysis.swept_langmuir.fit_functions.py

1e65c61

add to exclude_patterns "notebooks/langmuir_samples" and "*/.ipynb_ch…

3007c0e

…eckpoints"

create api_static stub file for plasmapy.analysis.swept_langmuir.fit_…

b18d451

…functions

implement FitFunctions; create FloatingPotentialResults namedtuple fo…

855a2ee

…r returning values; eliminate kwargs retfit and retislands; add kwarg fit_type; update behavior of min_points to all for all points, specified number of points, or a fraction of the array size

rocco8773 and others added 13 commits September 10, 2020 21:08

update docstrings to indicate implementation of namedtuple return

0c47065

Merge remote-tracking branch 'fork/ad-lang-vf' into ad-lang-vf

b770cca

# Conflicts: # plasmapy/analysis/swept_langmuir/floating_potential.py

Merge remote-tracking branch '_pp/master' into ad-lang-vf

a61a37d

it appears nbconvert>=6.0.0 is causing build errors on RTD...this is …

25a5f08

…to test that

change color of plot element for Vf

ce9b954

fix notebook misspellings

889cf81

add docstring to add_noise()

f1b1e82

update filename so ".npy" is not added twice when saving

1a97c86

add plotting of noise vs original signals

074bf0c

repair definition of file names...I did not properly update when I mo…

f5ecdb3

…ved it from it's previous notebook

replace use of os.path with pathlib.Path

e995cf4

blend my wording and Nick's (I prefer "task" over "responsibility")

e17b15a

Adding function plasma_potential.py

66eb074

gkbal requested a review from rocco8773 September 14, 2020 18:36

gkbal assigned rocco8773 and gkbal Sep 14, 2020

rocco8773 added this to In Progress | Draft in Swept Langmuir Overhaul via automation Sep 14, 2020

rocco8773 added 4 commits September 14, 2020 11:55

Merge branch 'ad-lang-vf' into pull/897-vp_by_didv

3989a80

# Conflicts: # plasmapy/analysis/swept_langmuir/__init__.py

change name find_plasma_potential() -> find_plasma_potential_didv(); …

d6472d1

…add module level docstrings; add imports; add __all__

fix typo

6a7c400

add stub file foe plasmapy.analysis.swept_langmuir.plasma_potential; …

132203e

…update doc for plasmapy.analysis.swept_langmuir

namurphy added the plasmapy.diagnostics Related to the plasmapy.diagnostics subpackage label Sep 19, 2020

rocco8773 added this to the 0.8.0 milestone Jul 20, 2021

rocco8773 mentioned this pull request Jan 25, 2022

[EPIC] Swept Langmuir Overhaul #1402

Open

9 tasks

rocco8773 modified the milestones: 0.8.0, 0.9.0 Apr 5, 2022

namurphy removed this from the 0.9.0 milestone Jul 6, 2022

namurphy added the status: dormant PRs that are stalled label May 26, 2023

namurphy added this to the Future milestone Apr 9, 2024

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Adding function find_plasma_potential_dI/dV #897

Adding function find_plasma_potential_dI/dV #897

gkbal commented Sep 14, 2020

codecov bot commented Sep 14, 2020 •

edited

Adding function find_plasma_potential_dI/dV #897

Are you sure you want to change the base?

Adding function find_plasma_potential_dI/dV #897

Conversation

gkbal commented Sep 14, 2020

codecov bot commented Sep 14, 2020 • edited

Codecov Report

codecov bot commented Sep 14, 2020 •

edited