Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Extension store ID incorrect #37

Open
louisgv opened this issue Mar 1, 2022 · 2 comments
Open

Extension store ID incorrect #37

louisgv opened this issue Mar 1, 2022 · 2 comments
Assignees
@louisgv
Labels
chrome Chrome Webstore Upload dependencies Pull requests that update a dependency file mozilla Mozilla Webstore Upload (AMO)

Comments

@louisgv
Copy link
Contributor

louisgv commented Mar 1, 2022 •
edited
Loading

https://github.com/AliasIO/wappalyzer/pull/5634

Also note that the deployment failed for both stores, BUT the action still reporting as success. Seems like 400 error are being ignored, we should check and throw error manually.

image
@louisgv louisgv added dependencies Pull requests that update a dependency file chrome Chrome Webstore Upload mozilla Mozilla Webstore Upload (AMO) labels Mar 1, 2022
@louisgv louisgv self-assigned this Mar 1, 2022
@louisgv louisgv mentioned this issue Mar 1, 2022
Merged
louisgv added a commit that referenced this issue Mar 2, 2022
@louisgv
Merge pull request #43 from plasmo-corp/fix-edge
7f379ca 
Bump bms to 1.4.0, fix #29 and #37 

- For AMO, the gecko.id will be used if specified, otherwise it fallback to extId
- For Edge, many of the puppeteer identifier were updated
@louisgv
Copy link
Contributor Author

louisgv commented Mar 2, 2022

This is solved with #41 and #43

@louisgv louisgv closed this as completed Mar 2, 2022
@louisgv louisgv reopened this Mar 18, 2022
@louisgv
Copy link
Contributor Author

louisgv commented Mar 18, 2022

Issue still occurring in WAppalyzer: https://github.com/AliasIO/wappalyzer/pull/5634#issuecomment-1071991549

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@louisgv louisgv

Labels
chrome Chrome Webstore Upload dependencies Pull requests that update a dependency file mozilla Mozilla Webstore Upload (AMO)
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@louisgv