Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BUG] Market client errors swallowed #86

Open
2 tasks done
nickderobertis-ch opened this issue Dec 20, 2023 · 0 comments
Open
2 tasks done

[BUG] Market client errors swallowed #86

nickderobertis-ch opened this issue Dec 20, 2023 · 0 comments
Labels
bug Something isn't working

Comments

@nickderobertis-ch
Copy link

What happened?

First, Plasmo is awesome and definitely making the Chrome extension dev experience better.

My extension was already in the Chrome Web Store, but I made some changes that required additional permissions. When I ran the bpp action, all I got in the output was:

🔴 ERROR  | Error: chrome: Step 2) Item "<redacted>": Response code 400 (Bad Request)

I tried the verbose option and setting chrome.verbose = true in the keys, to no avail.

I was able to fork the action and increase the detail of the error logging (which involved vendoring bms, as it actually swallows the useful information when it does getVerboseError).

Eventually I was able to see in the response body:

Publish condition not met: To publish your item, you must provide mandatory privacy information in the new Developer Dashboard: https://chrome.google.com/webstore/devconsole. Click on your item from the home page and enter this information on the Privacy practices tab.

Once I saw this it was easy to make the change in the web store and then the action was able to submit it successfully.

Could we get the 4xx responses from the extension stores displayed here? I think it will be very helpful for debugging issues.

I only tried Chrome though I have a feeling the issue exists for other stores.

If you want me to open this in bms instead I can, I think changes may be required in both. We could get away with only changes in bms if we put the response body into the error message though.

Which browsers are you seeing the problem on?

Chrome

Relevant log output

No response

Code of Conduct

  • I agree to follow this project's Code of Conduct
  • I checked the current issues for duplicate problems.
@nickderobertis-ch nickderobertis-ch added the bug Something isn't working label Dec 20, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

1 participant