Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(React router): Implemented react router dom api example #6

Merged
merged 5 commits into from Jun 17, 2022

Conversation

wadhia-yash
Copy link
Contributor

No description provided.

@ColdSauce
Copy link
Contributor

Hey @Aarush-wadhia thanks for the PR! Just a heads up, I think you have the jotai commits in here along with your react router ones.

@wadhia-yash
Copy link
Contributor Author

Hey @Aarush-wadhia thanks for the PR! Just a heads up, I think you have the jotai commits in here along with your react router ones.

Yes I have requested PR for jotai as well as for react router

@louisgv
Copy link
Contributor

louisgv commented Jun 16, 2022

@Aarush-wadhia can you move the react-router code into its own branch tree going from main - it seems the current branch started from your previous react-router commit.

@wadhia-yash
Copy link
Contributor Author

@Aarush-wadhia can you move the react-router code into its own branch tree going from main - it seems the current branch started from your previous react-router commit.

Opps!
Let me take care of this issue

@louisgv
Copy link
Contributor

louisgv commented Jun 17, 2022

I think you might have a stale fork after I merged your jotai example. Tho I think merging this should be fine as it will be squashed anyhow - Great work 馃檶

@louisgv louisgv merged commit cb9ec2c into PlasmoHQ:main Jun 17, 2022
@wadhia-yash
Copy link
Contributor Author

My react router branch was a few commits behind which caused the issue I didn't update my main branch. But things are taken care of.
Cheers! 馃嵒

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
3 participants