Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: adding --source-maps flag for production #189

Merged
merged 1 commit into from
Sep 7, 2022
Merged

feat: adding --source-maps flag for production #189

merged 1 commit into from
Sep 7, 2022

Conversation

louisgv
Copy link
Contributor

@louisgv louisgv commented Sep 6, 2022 •
edited

Details

  • closes #
  • If RFC, it has been approved for implementation.

Code of Conduct

  • I agree to follow this project's Code of Conduct
  • I checked the current PR for duplication.

@louisgv louisgv self-assigned this Sep 6, 2022
@louisgv louisgv linked an issue Sep 6, 2022 that may be closed by this pull request
[RFC] --source-map for production #184
Closed
3 tasks
ColdSauce
ColdSauce approved these changes Sep 6, 2022
View reviewed changes
Copy link
Contributor

@ColdSauce ColdSauce left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. The only question in my mind is whether these source maps will actually produce correctly. Last time I checked months ago, they didn't.

@louisgv
Copy link
Contributor Author

louisgv commented Sep 7, 2022

LGTM. The only question in my mind is whether these source maps will actually produce correctly. Last time I checked months ago, they didn't.

lol yeah we will see

@louisgv louisgv merged commit b49f120 into main Sep 7, 2022
@louisgv louisgv deleted the 184-rfc-source-map-for-production branch September 7, 2022 02:25
@leotronolone leotronolone mentioned this pull request Dec 1, 2022
Closed
2 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ColdSauce ColdSauce ColdSauce approved these changes

Assignees

@louisgv louisgv

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[RFC] --source-map for production
2 participants
@louisgv @ColdSauce