fix(parcel-core): only allow client-side env to be included #493
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
2 tasks
ColdSauce
approved these changes
Mar 9, 2023
|
There was a discussion on whether this should be a patch on top of parcel/core instead of a fork. Patching will allow us to have minimal footprint and make it easier to maintain/apply future upstream commit. My rationale for forking it is that it will encourage/forcing us to learn the internal in and out of parcel/core, since it powers the bulk of our compiler. The translation between flow -> TS will also allow us to have better grasp at the typing, instead of relying on Parcel usptream flow implementation. |
louisgv
deleted the
492-bug-private-env-are-being-written-into-final-bundle
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Details
Code of Conduct