fix: removeAll should account for namespace

PlasmoHQ · Apr 16, 2024 · e38313a · e38313a
1 parent 4f5a1ca
commit e38313a
Show file tree

Hide file tree

Showing 2 changed files with 7 additions and 6 deletions.
diff --git a/package.json b/package.json
@@ -1,6 +1,6 @@
 {
   "name": "@plasmohq/storage",
-  "version": "1.9.3",
+  "version": "1.10.0",
   "description": "Safely and securely store data and share them across your extension and websites",
   "type": "module",
   "module": "./src/index.ts",

diff --git a/src/index.ts b/src/index.ts
@@ -182,7 +182,9 @@ export abstract class BaseStorage {
     return changed
   }
 
-  protected rawGet = async (key: string): Promise<string | null | undefined> => {
+  protected rawGet = async (
+    key: string
+  ): Promise<string | null | undefined> => {
     if (this.hasExtensionApi) {
       const dataMap = await this.#primaryClient.get(key)
 
@@ -233,11 +235,10 @@ export abstract class BaseStorage {
   }
 
   removeAll = async () => {
-    // Using rawGetAll to retrieve all keys with namespace
-    const allData = await this.rawGetAll()
+    const allData = await this.getAll()
     const keyList = Object.keys(allData)
 
-    await Promise.all(keyList.map(this.rawRemove))
+    await Promise.all(keyList.map(this.remove))
   }
 
   watch = (callbackMap: StorageCallbackMap) => {
@@ -255,7 +256,7 @@ export abstract class BaseStorage {
       callbackSet.add(callbackMap[cbKey])
 
       if (callbackSet.size > 1) {
-        continue;
+        continue
       }
 
       const chromeStorageListener = (