Fix missing name in the Tooltip of an asset locked #1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…hen it is Loaked by someone else or in another workspace In FPlasticSourceControlState::GetDisplayTooltip() the switch(WorkspaceState) was missing case EWorkspaceState::LockedByOther I have checked and it is the only place where it was missing It wasn't needed in past version of Unreal because the Editor was calling FPlasticSourceControlState::IsCheckedOutOther(FString* Who) to retrieve the name, but they changed the usage of the API
juliomaqueda
approved these changes
Mar 24, 2022
jessica-gutierrez
approved these changes
Mar 24, 2022
SRombautsU
deleted the
fix-missing-checked-out-by-other-username-tooltop
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In FPlasticSourceControlState::GetDisplayTooltip()
the switch(WorkspaceState)
was missing case EWorkspaceState::LockedByOther
I have checked and it is the only place where it was missing
It wasn't needed in past version of Unreal because the Editor was calling FPlasticSourceControlState::IsCheckedOutOther(FString* Who) to retrieve the name, but they changed the usage of the API