Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add operations to delete and rename branches #100

Merged
merged 13 commits into from Dec 7, 2023

Conversation

SRombautsU
Copy link

@SRombautsU SRombautsU commented Nov 29, 2023

  • New RunRenameBranch() Utils to execute cm branch rename
  • New RunDeleteBranches() Utils to execute cm branch delete
  • New "RenameBranch" Operation and Worker calling the corresponding new Utils
  • New "DeleteBranches" Operation and Worker calling the corresponding new Utils
  • Change the Branches window handle Multi Selection in preparation for the DeleteBranch operation
  • Add a menu entry, a RenameBranch method calling the operation, and a callback on completion
  • Add a menu entry, a DeleteBranches() method calling the operation, and a callback on completion
  • Add the Rename Widget UI that let the user edit the old name. The Escape key can be used to Cancel and close the dialog.
  • Add the Delete Widget UI displaying the list of branches. User the Enter key is enough to automatically proceed, while Escape can be used to cancel and close the dialog.

@SRombautsU SRombautsU self-assigned this Nov 29, 2023
@SRombautsU SRombautsU force-pushed the 1004372-delete-and-rename-branches branch 5 times, most recently from e027d90 to 8d0cc0a Compare December 4, 2023 10:14
@SRombautsU SRombautsU marked this pull request as ready for review December 4, 2023 10:50
@SRombautsU SRombautsU force-pushed the 1004372-delete-and-rename-branches branch 2 times, most recently from 25f0a23 to c103c1e Compare December 5, 2023 14:43
@SRombautsU SRombautsU changed the title 1004372 delete and rename branches Add operations to delete and rename branches Dec 6, 2023
@SRombautsU SRombautsU force-pushed the 1004372-delete-and-rename-branches branch from c103c1e to 65bf6e5 Compare December 6, 2023 08:48
@SRombautsU SRombautsU force-pushed the 1004372-delete-and-rename-branches branch from 4ceabba to 301b4fc Compare December 7, 2023 11:02
Refresh the list of branches
Switch workspace to the selected branch
Delete the selected branches

Both actions have a confirmation dialog
@SRombautsU SRombautsU force-pushed the 1004372-delete-and-rename-branches branch from 301b4fc to 4a2df7d Compare December 7, 2023 14:13
Copy link

@danielhompanera danielhompanera left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@SRombautsU SRombautsU merged commit 8c489cc into master Dec 7, 2023
@SRombautsU SRombautsU deleted the 1004372-delete-and-rename-branches branch December 7, 2023 14:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants