forked from SRombauts/UEPlasticPlugin
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add operations to delete and rename branches #100
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
SRombautsU
commented
Nov 29, 2023
•
edited
edited
- New RunRenameBranch() Utils to execute cm branch rename
- New RunDeleteBranches() Utils to execute cm branch delete
- New "RenameBranch" Operation and Worker calling the corresponding new Utils
- New "DeleteBranches" Operation and Worker calling the corresponding new Utils
- Change the Branches window handle Multi Selection in preparation for the DeleteBranch operation
- Add a menu entry, a RenameBranch method calling the operation, and a callback on completion
- Add a menu entry, a DeleteBranches() method calling the operation, and a callback on completion
- Add the Rename Widget UI that let the user edit the old name. The Escape key can be used to Cancel and close the dialog.
- Add the Delete Widget UI displaying the list of branches. User the Enter key is enough to automatically proceed, while Escape can be used to cancel and close the dialog.
SRombautsU
force-pushed
the
1004372-delete-and-rename-branches
branch
5 times, most recently
from
December 4, 2023 10:14
e027d90
to
8d0cc0a
Compare
SRombautsU
force-pushed
the
1004372-delete-and-rename-branches
branch
2 times, most recently
from
December 5, 2023 14:43
25f0a23
to
c103c1e
Compare
SRombautsU
changed the title
1004372 delete and rename branches
Add operations to delete and rename branches
Dec 6, 2023
SRombautsU
force-pushed
the
1004372-delete-and-rename-branches
branch
from
December 6, 2023 08:48
c103c1e
to
65bf6e5
Compare
…the DeleteBranch operation
…callback on completion Can only be executed for a selection of a single branch
…d a callback on completion TODO: we need the Dialog window to ask the user for confirmation!
The Escape key can be used to Cancel and close the dialog
User the Enter key is enough to automatically proceed, while Escape can be used to cancel and close the dialog.
…(but did work in Debug) Using a pointer to a TCHAR var in a function taking a string
SRombautsU
force-pushed
the
1004372-delete-and-rename-branches
branch
from
December 7, 2023 11:02
4ceabba
to
301b4fc
Compare
Refresh the list of branches Switch workspace to the selected branch Delete the selected branches Both actions have a confirmation dialog
SRombautsU
force-pushed
the
1004372-delete-and-rename-branches
branch
from
December 7, 2023 14:13
301b4fc
to
4a2df7d
Compare
danielhompanera
approved these changes
Dec 7, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.