Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix history of a renamed asset #103

Merged
merged 5 commits into from Jan 10, 2024

Conversation

SRombautsU
Copy link

An asset that as been renamed was showing up with a "deleted" cross icon in its history
image
image

  • Removed duplicated and unused FileStateToAction() from Utils. It belongs in Parsers, where it is used.
  • Change FileStateToAction() to extract and use directly the source control action text strings. Better than calling the function in the parser's inner loop!
  • cm delivers the history into an XML file. instead of outputting it directly on the standard output of the shell

It belongs in Parsers, where it is used
…trol action text strings

Better than calling the function in the parser's inner loop!
instead of outputting it directly on the standard output of the shell
@SRombautsU SRombautsU added the bug label Jan 9, 2024
@SRombautsU SRombautsU self-assigned this Jan 9, 2024
There are two entries in the history for a Move of an asset;

1. a regular one with the normal data: revision, comment, branch, Id, size, hash etc.
2. and another "empty" one for the Move

=> Since the parsing is done in reverse order, the detection of a Move need to apply to the next entry
Raises a flag to treat the next entry as a Move, and skip this one as it is empty (it's just an additional entry with data for the move)
@juliomaqueda juliomaqueda merged commit ba62d52 into master Jan 10, 2024
@juliomaqueda juliomaqueda deleted the 1004224-fix-history-renamed-asset branch January 10, 2024 10:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
2 participants