Implement FPlasticSourceControlMenu::OpenDeskoptApp() #106
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Checks the Windows Registry to find Unity Version Control install location - Implemented and test for both the regular "Plastic" GUI and Gluon Also implemented the correct application & path for MacOS and symlinks for Linux, but they are not supported and not tested at all.
juliomaqueda
requested changes
Jan 18, 2024
There was a problem hiding this comment.
Great work @SRombautsU!
Please, checkout the minor comments I added.
Source/PlasticSourceControl/Private/PlasticSourceControlMenu.cpp
Outdated
Show resolved
Hide resolved
Source/PlasticSourceControl/Private/PlasticSourceControlMenu.cpp
Outdated
Show resolved
Hide resolved
Only triggers an issue when bUseUnityBuild = true; in UE5PlasticPluginDevEditor.Target.cs (the default) since the Unity Builds principle make the imported Windows symbols bleeds into all other compiled files as well
SRombautsU
force-pushed
the
1003908-open-desktop-app
branch
2 times, most recently
from
7df3f21
to
38aed1b
Compare
…dDesktopApplicationPath()
SRombautsU
force-pushed
the
1003908-open-desktop-app
branch
from
38aed1b
to
38f8bdd
Compare
juliomaqueda
approved these changes
Jan 19, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Also implemented the correct application & path for MacOS and symlinks for Linux, but they are not supported and not tested at all.