forked from SRombauts/UEPlasticPlugin
-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix and cleanup status command using --all flags #12
Merged
SRombautsU
merged 2 commits into
PlasticSCM:master
from
SRombautsU:clean-status-command-using--all-flag
Apr 6, 2022
Merged
Fix and cleanup status command using --all flags #12
SRombautsU
merged 2 commits into
PlasticSCM:master
from
SRombautsU:clean-status-command-using--all-flag
Apr 6, 2022
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
SRombautsU
changed the title
Cleanup status command using --all flags
Fix and cleanup status command using --all flags
Mar 31, 2022
As per the help: --all This flag replaces the following parameters: '--controlledchanged', '--changed', '--localdeleted', '--localmoved', '--private'. Also adding back some --header / --nochanges flags from the initial GetWorkspaceInfo() that I removed by mistake when trying to clean up the code previously Also updating all the comments about the version 8.0.16.3000 with the obsolete link to release notes
Before: LogSourceControl: RunCommand(8): 'status --compact --noheaders --all --ignored "C:/Workspace/UE4PlasticPluginDev/Content/ThirdPersonBP/Blueprints"' (in 0.006773s) output (57 chars): cs:2@rep:UE4PlasticPluginDev@repserver:localhost:8087 After: LogSourceControl: RunCommand: 'status --compact --noheaders --all --ignored "C:/Workspace/UE4PlasticPluginDev/Content/ThirdPersonBP/Blueprints"' (in 0.010225s) output (57 chars): cs:2@rep:UE4PlasticPluginDev@repserver:localhost:8087
Before:
|
After:
Cleaner "status" with less flags and cleaner RunCommand without the counter showing in all logs:
|
jessica-gutierrez
approved these changes
Apr 6, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Also adding back some --header / --nochanges flags from the initial GetWorkspaceInfo() that I removed by mistake when trying to clean up the code previously
Also updating all the comments about the version 8.0.16.3000 with the obsolete link to release notes