Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix and cleanup status command using --all flags #12

Merged
merged 2 commits into from
Apr 6, 2022
Merged

Fix and cleanup status command using --all flags #12

merged 2 commits into from
Apr 6, 2022

Conversation

SRombautsU
Copy link

Also adding back some --header / --nochanges flags from the initial GetWorkspaceInfo() that I removed by mistake when trying to clean up the code previously

Also updating all the comments about the version 8.0.16.3000 with the obsolete link to release notes

@SRombautsU SRombautsU self-assigned this Mar 30, 2022
@SRombautsU SRombautsU changed the title Cleanup status command using --all flags Fix and cleanup status command using --all flags Mar 31, 2022
As per the help:
 --all  This flag replaces the following parameters:
        '--controlledchanged', '--changed',
        '--localdeleted', '--localmoved', '--private'.

Also adding back some --header / --nochanges flags from the initial GetWorkspaceInfo() that I removed by mistake when trying to clean up the code previously

Also updating all the comments about the version 8.0.16.3000 with the obsolete link to release notes
Before:
LogSourceControl: RunCommand(8): 'status --compact --noheaders --all --ignored "C:/Workspace/UE4PlasticPluginDev/Content/ThirdPersonBP/Blueprints"' (in 0.006773s) output (57 chars):
cs:2@rep:UE4PlasticPluginDev@repserver:localhost:8087

After:
LogSourceControl: RunCommand: 'status --compact --noheaders --all --ignored "C:/Workspace/UE4PlasticPluginDev/Content/ThirdPersonBP/Blueprints"' (in 0.010225s) output (57 chars):
cs:2@rep:UE4PlasticPluginDev@repserver:localhost:8087
@SRombautsU
Copy link
Author

SRombautsU commented Apr 4, 2022

Before:
Startup is showing "changes" insted of just the header ending with "Branch /main@..."

LogSourceControl: RunCommand(4): 'status --compact --wkconfig' (in 0.209904s) (output 500 chars not displayed)
LogSourceControl: Verbose: cs:2@rep:UE4PlasticPluginDev@repserver:localhost:8087
Branch /main@rep:UE4PlasticPluginDev@repserver:localhost:8087
Modified items (CH = changed, CO = checked-out, CP = copied (new), RP = replaced)
 CH Config\DefaultEngine.ini
 CH ignore.conf
Added items (AD = added, PR = private, IG = ignored)
 PR Build.bat
 PR BuildAndPackageForRelease.bat
 PR GenerateProjectFiles.bat
 PR README.md
 PR Script
 PR UE4PlasticPlugin-1.4.12-with-debug-symbols.zip
 PR UE4PlasticPlugin-1.4.12.zip
LogSourceControl: Verbose: RunCommand(4): cumulated time spent in shell: 1.646230s
LogSourceControl: Verbose: RunUpdateStatus: 7 file(s)/1 directory(ies) ('C:/Workspace/UE4PlasticPluginDev/Content/ThirdPersonBP/Blueprints/BP_Added.uasset'...)
LogSourceControl: Verbose: RunCommand(8): 'status --compact --noheaders --controlledchanged --changed --localdeleted --localmoved --private --ignored "C:/Workspace/UE4PlasticPluginDev/Content/ThirdPersonBP/Blueprints"' (175 chars, 1 files)
LogSourceControl: RunCommand(8): 'status --compact --noheaders --controlledchanged --changed --localdeleted --localmoved --private --ignored "C:/Workspace/UE4PlasticPluginDev/Content/ThirdPersonBP/Blueprints"' (in 0.004028s) output (57 chars):
cs:2@rep:UE4PlasticPluginDev@repserver:localhost:8087
LogSourceControl: Verbose: RunCommand(8): cumulated time spent in shell: 1.712650s

@SRombautsU
Copy link
Author

SRombautsU commented Apr 4, 2022

After:
Cleaner startup:

LogSourceControl: RunCommand: 'status --compact --header --wkconfig' (in 0.126962s) output (118 chars):
cs:2@rep:UE4PlasticPluginDev@repserver:localhost:8087
Branch /main@rep:UE4PlasticPluginDev@repserver:localhost:8087
LogSourceControl: Verbose: RunCommand: cumulated time spent in shell: 1.664772s (count 4)

Cleaner "status" with less flags and cleaner RunCommand without the counter showing in all logs:

LogSourceControl: Verbose: RunUpdateStatus: 7 file(s)/1 directory(ies) ('C:/Workspace/UE4PlasticPluginDev/Content/ThirdPersonBP/Blueprints/BP_Added.uasset'...)
LogSourceControl: Verbose: RunCommand: 'status --compact --noheaders --all --ignored "C:/Workspace/UE4PlasticPluginDev/Content/ThirdPersonBP/Blueprints"' (113 chars, 1 files)
LogSourceControl: RunCommand: 'status --compact --noheaders --all --ignored "C:/Workspace/UE4PlasticPluginDev/Content/ThirdPersonBP/Blueprints"' (in 0.005981s) output (57 chars):
cs:2@rep:UE4PlasticPluginDev@repserver:localhost:8087
LogSourceControl: Verbose: RunCommand: cumulated time spent in shell: 1.786210s (count 8)

@SRombautsU SRombautsU added the bug label Apr 6, 2022
@SRombautsU SRombautsU merged commit c311e9b into PlasticSCM:master Apr 6, 2022
@SRombautsU SRombautsU deleted the clean-status-command-using--all-flag branch April 6, 2022 16:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants