Fix source control menu extension to work with UE5 #15
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
PlatformFilemanager.h was renamed PlatformFileManager
SRombautsU
changed the title
The old FLevelEditorMenuExtender is not used anymore by the Editor, so calling it does nothing. The official multi-user editing plugin "Concert" had to switch to the "ToolMenus" package, so I borrowed the new method they switched to and adapted the source code. edit: added the missing call to Unnregister(). I had to make it robust to double calls, happening when closing the Editor. Also removed an old unused "PlasticSourceControlMenu" FName variable
jessica-gutierrez
approved these changes
Apr 6, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The old FLevelEditorMenuExtender is not used anymore by the Engine, so trying to use it does nothing.
The official multi-user editing plugin "Concert" had to switch to the "ToolMenus" package,
so I borrowed the new method they switched to and adapted the source code.