Fix restart shell after timeout #22
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… using it in case of a timeout - Check the ShellProcessHandle inside the function instead of outside - Check if IsProcessRunning() before calling "exit" - Don't use _RunCommandInternal() anymore so we don't risk recursive calls, directly write to the pipe - Warn if the shell didn't exit in time, before killing it
…ags in FPlatformProcess::CreatePipe() This has been fixed in January 2022 for UE 5.0
And in any case, it will be restarted if needed inside _RunCommandInternal()
jessica-gutierrez
approved these changes
Apr 21, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Improve internal _ExitBackgroundCommandLineShell(), use it for _RestartBackgroundCommandLineShell(), and use this one in case of Timeout
Also add #ifdef UE4 around CreatePipeWrite() now that UE5 support it correctly