Fix connection error detection and reconnection #31
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
SRombautsU
commented
May 30, 2022
SRombautsU
commented
- wrong error message if you just unplug the cable/disable the Plastic SCM service, it tells something like "no workspace available)
- when the server get back online, the Editor didn't ever fully recover, keep showing the "server unavailable" icon
…erver Unavailable" icon - Implement FPlasticSourceControlProvider::SetLastErrors() similarly than the Perforce plugin - SetLastErrors() only in case of a connection error (or for the reconnection) - Use the last error as the message to display in the tooltip
…d correctly to the server - Detect server connection and repository missing thanks to GetWorkspaceInformation(), no need for "checkconnection" - Forward GetWorkspaceName() and GetWorkspaceInformation() ErrorMessages up to the Provider so they can be displayed
It is often "count 1" displayed in loop for each retry
Useful if stuck because missing credentials; will now be able to display the question asked by cm shell
The cm process could stay up and they would accumulate on each restart Use case: clear the user profile for a cloud server and it will keep timeout in 180s and try to restart a new cm shell
…l quickly Interrupt any running cm command instead of waiting up to the timeout of 180s that was keeping the Editor as a "zombie" locking assets and showing in the task manager
jessica-gutierrez
approved these changes
Jun 1, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.