Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Detect unsupported PlasticSCM version and warn users #37

Merged
merged 6 commits into from
Jul 8, 2022
Merged

Detect unsupported PlasticSCM version and warn users #37

merged 6 commits into from
Jul 8, 2022

Conversation

SRombautsU
Copy link

No description provided.

@SRombautsU SRombautsU self-assigned this Jul 6, 2022
Missing endline at the end of files
Extra space after/before parenthesis
On extra line on a function call
since we in fact need a more recent version for changelist support
…ed one and warn the user with a popup asking them to update it

For now, I think the minimal version of Plastic SCM that would support changelists correctly would be:
https://www.plasticscm.com/download/releasenotes/9.0.16.4839 cm changelist 'persistent' flag now contain a '--' prefix.
…t can be displayed in the plugin UI like other errors
Copy link

@mig42 mig42 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me!

@SRombautsU SRombautsU merged commit e5d93c3 into PlasticSCM:master Jul 8, 2022
@SRombautsU SRombautsU deleted the 1001592-detect-unsuported-plastic-version branch July 8, 2022 15:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants