Fix shared collection: assumes that the default source control status 'Unknown' is "in source control" #50
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… 'Unknown' is "in source control"
I had to debug the Perforce plugin to understand that this part of the Editor rely on the fact that "Collections" (".collection" files) are always in source control and never changed locally since the Editor does auto checkout+change+checkin
The Perforce plugin assumes that all files are in the "DontCare" state by default that is either 'Unknown' OR 'Controlled' (vs the Plastic SCM plugin uses a dedicated 'Unknown' state). I think I'll have to drop the Unknown state and mimic the behavior of the Perforce plugin going forward
juliomaqueda
approved these changes
Nov 25, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I had to debug the Perforce plugin to understand that this part of the Editor rely on the fact that "Collections" (".collection" files) are always in source control and never changed locally since the Editor does auto checkout+change+checkin
The Perforce plugin assumes that all files are in the "DontCare" state by default that is either 'Unknown' OR 'Controlled' (vs the Plastic SCM plugin uses a dedicated 'Unknown' state). I think I'll have to drop the Unknown state and mimic the behavior of the Perforce plugin going forward