Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix sync/update workspace in partial workspace #52

Merged
merged 3 commits into from Nov 29, 2022

Conversation

SRombautsU
Copy link

@SRombautsU SRombautsU commented Nov 28, 2022

Until recently this operation was crashing in Unreal Engine 5 at the end of the lengthy Reload Package operation.
When I fixed the regular workspace mode, this partial mode ended up not reloading anything anymore (so not crashing either ;)

  • Rename RunSync() to RunUpdate() to match with the underlying cm operation (same with ParseUpdateResults())
  • Implement a new variant of ParseUpdateResults() variant to parse cm partial update --report --machinereadable

…tion

Also rename ParseSyncResults() to ParseUpdateResults()
@SRombautsU SRombautsU added the bug label Nov 28, 2022
@SRombautsU SRombautsU self-assigned this Nov 28, 2022
@SRombautsU SRombautsU force-pushed the 1002225-fix-sync-in-partial-workspace branch from 0c5f542 to 1409e5d Compare November 28, 2022 14:50
@juliomaqueda juliomaqueda self-requested a review November 29, 2022 09:05
@juliomaqueda juliomaqueda merged commit 59a901e into master Nov 29, 2022
@juliomaqueda juliomaqueda deleted the 1002225-fix-sync-in-partial-workspace branch November 29, 2022 09:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
2 participants