Fix cm shell timeout if the cli doesn't have credentials saved #55
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…timeout since the shell is blocked and won't be able to exit in time anyway
SRombautsU
force-pushed
the
1001290-fix-cm-shell-authenticate-timeout
branch
4 times, most recently
from
74c3d13
to
19e9091
Compare
- Display a failure notification and output an error message - Restart the shell immediately instead of waiting until the 3 minutes timeout This will provoke a series of 2 to 4 retries and notifications for each successive attempt from the Unreal Editor to update 1. check of the server connection 2. status of a Config file 3. status of the assets in view in the content browser (if any subfolder is open) 4. status of changeslists (if the View Changelists window is opened)
SRombautsU
force-pushed
the
1001290-fix-cm-shell-authenticate-timeout
branch
from
19e9091
to
0852ef2
Compare
SRombautsU
changed the title
…lse when the underlying RunStatus() returns false
…cted to the Message Log window
juliomaqueda
approved these changes
Dec 14, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
_RestartBackgroundCommandLineShell() can now Force Exit for cases of timeout since the shell is blocked and won't be able to exit in time anyway