Fix checkin changelist with blank comment #66
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…g any change to its description It's a bug with the UI of the Unreal Editor itself, that trigger a checkin with an empty description, so we retrieve it directly from the changelist in this specific case.
…ld changelist (else it recreates a phantom of the old changelist in the cache)
SRombautsU
force-pushed
the
1002896-checkin-changelist-with-blank-comment
branch
from
5ea8902
to
57addad
Compare
juliomaqueda
approved these changes
Feb 9, 2023
juliomaqueda
deleted the
1002896-checkin-changelist-with-blank-comment
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix missing changeset comment when checkin a changelist without making any change to its description.
It's in fact a bug with the UI of the Unreal Editor itself, that trigger a checkin with an empty description!
so we retrieve it directly from the changelist in this specific case.