Also add support for ShouldDeleteNewFiles to the RevertAll operation #68
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…e they hold to the said changelist
… the regular Revert
juliomaqueda
approved these changes
Feb 10, 2023
juliomaqueda
deleted the
1002930-apply-soulddeletenewfiles-to-revertall
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Unreal Engine 5 added a Source Control project settings to let users decide if they want to delete newly added files when calling Revert (true by default).
The first PR SRombauts#124 covered the support for that parameter for the regular "Revert" operation, but we didn't implemented it for our custom global "RevertAll" operation!
This new PR adresses that, while also refactoring a bit the code around so there is less duplicates and less #ifdef