Fix crash ArrayIndexOutOfBoundsException when opening a project hosted On Prem #80
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…d On Prem The bug was in PlasticSourceControlUtils::ParseWorkspaceInfo() when spliting the "WorkspaceInfo" on the separator '@', since there is only 4 parts to is when on the @cloud, compare: - Branch /main@UE5PlasticPluginDev@test@cloud - Branch /main@UE5PlasticPluginDev@localhost:8087
juliomaqueda
approved these changes
May 26, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The bug was in PlasticSourceControlUtils::ParseWorkspaceInfo() when splitting the "WorkspaceInfo" on the separator '@', since there is only 4 parts to is when on the @cloud, compare:
This function is called once at Init() of the source control provider, so it was crashing the whole Editor right after project load.
Introduced by Commit 7141f0a by Sébastien Rombauts, 04/12/2023 04:55 PM as part of pull request #78 from PlasticSCM/1003296-fix-cm-status-replaced-unchanged so it wasn't released yet since it came after 1.8.0