Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix small status icons showing a checkboard in UE5.2 #82

Merged
merged 2 commits into from Jun 12, 2023
Merged

Fix small status icons showing a checkboard in UE5.2 #82

merged 2 commits into from Jun 12, 2023

Conversation

SRombautsU
Copy link

  • Fix most of the small status icons by merging the change from UE5.2: switched from using FAppStyle to the new FRevisionControlStyleManager
  • Fix the remaining 3 custom icons by switching back to standard icons like we had before UE5.1

@SRombautsU SRombautsU added the bug label Jun 9, 2023
@SRombautsU SRombautsU self-assigned this Jun 9, 2023
@SRombautsU
Fix most of the small status icons by merging the change from UE5.2
4655a67 
Switched from using FAppStyle to the new FRevisionControlStyleManager
@SRombautsU
Remove our 3 custom icons that were relying on the AppStyle in UE5.1
801afbc 
Switched back to what we had before that;
- Ignored => no icon
- Changed => NotInDepot
- LocallyDeleted => Deleted

We cannot do anything else then fully switching to the FRevisionControlStyleManager standard icons because of how the GetIconName() APi is used by the Editor in SSourceControlSubmitWidget::GenerateWidgetForItemAndColumn()

                SNew(SImage)
                .Image(FRevisionControlStyleManager::Get().GetBrush(Item->GetIconName()))
                .ToolTipText(Item->GetIconTooltip())
@SRombautsU SRombautsU force-pushed the 1003408-fix-small-icons-ue52 branch from 662d784 to 801afbc Compare June 9, 2023 10:25
@juliomaqueda juliomaqueda self-requested a review June 12, 2023 11:31
@juliomaqueda juliomaqueda merged commit 1cb8940 into master Jun 12, 2023
@juliomaqueda juliomaqueda deleted the 1003408-fix-small-icons-ue52 branch June 12, 2023 11:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@juliomaqueda juliomaqueda juliomaqueda approved these changes

Assignees

@SRombautsU SRombautsU

Labels
bug
Projects
None yet
Milestone
No milestone
2 participants
@SRombautsU @juliomaqueda