Fix ongoing workspace creation shouldn't be interrupted if the users close the window too early

[SRombautsU]

• Split OnSourceControlOperationComplete() methods in dedicated delegates
• Move workspace creation parameters into a dedicated structure
• Move the workspace creation logic into a dedicated class: the instance is hold by the module, and kept alive when the Login window is closed (this is the actual fix)

[danielhompanera]

LGTM
I'm interested on knowing why the dedicated delegates do the trick. Even it seems like a much more appropiated approach, I'm curious to know why it wasn't working previously. Wasn't OnSourceControlOperationComplete being called correctly when the settings dialog is was closed?

[danielhompanera]

You mean "next" not "following" I think

[SRombautsU]

LGTM I'm interested on knowing why the dedicated delegates do the trick. Even it seems like a much more appropriate approach, I'm curious to know why it wasn't working previously. Wasn't OnSourceControlOperationComplete being called correctly when the settings dialog is was closed?

Indeed, this is just a refactor to make things cleaner while I was at the task, it's not the fix.
OnSourceControlOperationComplete (or any delegate) was not called if the "Login/workspace creation Window" was closed too early as the delegate was attached to the Windows itself

So the fix is in fact in the following commit:

Move the workspace creation logic into a dedicated class

The single instance of FPlasticSourceControlWorkspaceCreation is held by the Module,
and as such it is kept alive when the Login window is closed