hash economic config and save the result to stateDB #1333
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
bglmmz
commented
Apr 16, 2020
bglmmz
commented
- update gov.config variable type from float64 to uint64
- hash economic config and save the result to stateDB
- make sure endVotingBlock is higher than submitBlock
GavinXu520
reviewed
Apr 16, 2020
Comment on lines
+30
to
+31
| const RateCoefficient = uint64(10000) | ||
|
|
There was a problem hiding this comment.
This needs to add a comment message
core/genesis_data.go
Outdated
Comment on lines
317
to
319
| func genesisGovernParamData(prevHash common.Hash, snapdb snapshotdb.BaseDB, genesisVersion uint32) (common.Hash, error) { | ||
| func genesisGovernParamData(economicModel *xcom.EconomicModel, prevHash common.Hash, snapdb snapshotdb.BaseDB, genesisVersion uint32) (common.Hash, error) { | ||
| return gov.InitGenesisGovernParam(prevHash, snapdb, genesisVersion) | ||
| } |
There was a problem hiding this comment.
Is this economicModel useless in this function? Useless parameters need to be deleted
cheng762
approved these changes
Apr 16, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.