Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update compilation steps #1740

Merged

Conversation

WeiLoy
Copy link
Contributor

@WeiLoy WeiLoy commented Mar 24, 2021

No description provided.

Copy link
Member

@benbaley benbaley left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

according to releasenotes of golang_v1.16 go mod is not auto download
please add comment


```
git clone https://github.com/PlatONnetwork/PlatON-Go.git --recursive

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

missing 'cd PlatON-Go' ?

@codecov-io
Copy link

Codecov Report

❗ No coverage uploaded for pull request base (feature-mainnet-launch@958122f). Click here to learn what that means.
The diff coverage is n/a.

Impacted file tree graph

@@                    Coverage Diff                    @@
##             feature-mainnet-launch    #1740   +/-   ##
=========================================================
  Coverage                          ?   50.27%           
=========================================================
  Files                             ?      462           
  Lines                             ?    56556           
  Branches                          ?        0           
=========================================================
  Hits                              ?    28435           
  Misses                            ?    24622           
  Partials                          ?     3499           
Flag Coverage Δ
unittests 50.27% <0.00%> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.


Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 958122f...c5ed636. Read the comment docs.

@benbaley benbaley merged commit a3d08b6 into PlatONnetwork:feature-mainnet-launch Mar 25, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants