Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve setup documentation. Add ENV vars for easier configuration #26

Closed
wants to merge 6 commits into from

Conversation

microstudi
Copy link
Contributor

@microstudi microstudi commented Sep 16, 2022

This PR improves documentation on how to setup this plugin on Drupal/CiViCRM side and allows the use of coherent ENV vars instead of having to create initiatlizers (although compatibility is maintained).

It also adds a default icon to the login page:

Screenshot from 2022-09-16 13-43-16

@microstudi microstudi changed the title Docs envs Improve setup documentation. Add ENV vars for easier configuration Sep 16, 2022
@codecov
Copy link

codecov bot commented Sep 16, 2022

Codecov Report

Base: 59.74% // Head: 61.37% // Increases project coverage by +1.63% 🎉

Coverage data is based on head (03e98dc) compared to base (41fcc5a).
Patch coverage: 74.19% of modified lines in pull request are covered.

Additional details and impacted files
@@            Coverage Diff             @@
##             main      #26      +/-   ##
==========================================
+ Coverage   59.74%   61.37%   +1.63%     
==========================================
  Files          77       77              
  Lines        1463     1468       +5     
==========================================
+ Hits          874      901      +27     
+ Misses        589      567      -22     
Impacted Files Coverage Δ
lib/decidim/civicrm/version.rb 0.00% <0.00%> (ø)
...rators/decidim/civicrm/templates/civicrm_config.rb 0.00% <0.00%> (ø)
...s/decidim/civicrm/templates/test_civicrm_config.rb 0.00% <0.00%> (ø)
lib/decidim/civicrm/engine.rb 91.83% <75.00%> (-5.99%) ⬇️
...concerns/decidim/civicrm/needs_civicrm_snippets.rb 100.00% <100.00%> (ø)
lib/decidim/civicrm.rb 100.00% <100.00%> (ø)
lib/decidim/civicrm/api.rb 95.83% <100.00%> (ø)
lib/omniauth/strategies/civicrm.rb 96.77% <100.00%> (+38.15%) ⬆️
... and 1 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@microstudi microstudi mentioned this pull request Nov 3, 2022
@microstudi microstudi closed this Aug 15, 2023
@microstudi microstudi deleted the docs-envs branch August 15, 2023 07:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant