Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PlatziGame Terminado #2

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

LuisGerardoDC
Copy link

No description provided.

Copy link
Contributor

@teffcode teffcode left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Amazing Job 🚀

Average:

HTML: 100%
CSS: 100%
JS: 100%

Things we can improve:

  • Be more consistent with the whitespaces between HTML Tags (Like line 67 of index.html)
  • Be more consisten with the language on the code. I saw English (whinerLabel , healtPlayers...) and Spanish (jugadores, actualizarBarraDeVida...).
  • Remove console.log(). If you have a server error, you can show to the user that something happens.
  • Be more consistent with the whitespaces between functions and variables in JS. (For example: Remove line 26 and add whitespaces between functions.)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants