Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Reto completado #4

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Reto completado #4

wants to merge 2 commits into from

Conversation

franciscoagx
Copy link

No description provided.

@franciscoagx franciscoagx changed the title prework frontend terminado Reto completado Aug 17, 2020
teffcode
teffcode reviewed Aug 23, 2020
View reviewed changes
Copy link
Contributor

@teffcode teffcode left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Amazing Job 🚀

Average:

  • HTML: 100%
  • CSS: 100%
  • JS: 100%

Things we can improve:

  • Be more consistent with the whitespaces between HTML Tags (Like line 57 of index.html)
  • Be more consistent with the classnames (HTML) and variable names (JS). For example, btn2 is the "Play again" button in HTML but btn2 is "player2_play" button in JS.
  • Be more consisten with the language on the code. I saw English (getGif) and Spanish (vida1, jugar...).
  • When I click on "Play again", the modal doesn't disappear 😥 I didn't see on the code something like: modal.style.visibility = "hidden".

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@teffcode teffcode teffcode left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@franciscoagx @teffcode