Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Search update feature issues #36

Closed
Depal1 opened this issue Jul 14, 2022 · 1 comment · Fixed by #45
Closed

Search update feature issues #36

Depal1 opened this issue Jul 14, 2022 · 1 comment · Fixed by #45
Labels
bug Something isn't working

Comments

@Depal1
Copy link
Member

Depal1 commented Jul 14, 2022

The search update feature on PlayCover is triggering on Github pre-releases. Is this expected behavior?

On another note, it is directing to a .zip instead of the currently used .dmg.

Example: it is directing to https://github.com/PlayCover/PlayCover/releases/download/1.0.7/PlayCover.1.0.7.zip

instead of https://github.com/PlayCover/PlayCover/releases/download/1.0.7/PlayCover_1.0.7.dmg

@Depal1 Depal1 added the bug Something isn't working label Jul 14, 2022
@ohaiibuzzle
Copy link
Member

From what I can tell, the update code doesn't really do any checking of whether or not the release is a pre-release.
And it is indeed hardcoded to .zip instead of .dmg as seen here

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants