Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Implement Sparkle Updater #45

Merged
merged 22 commits into from Jul 29, 2022
Merged

feat: Implement Sparkle Updater #45

merged 22 commits into from Jul 29, 2022

Conversation

Candygoblen123
Copy link
Member

@Candygoblen123 Candygoblen123 commented Jul 16, 2022

This PR implements Sparkle Updater for distributing updates

@Candygoblen123 Candygoblen123 changed the base branch from master to develop July 16, 2022 02:50
@Candygoblen123 Candygoblen123 marked this pull request as draft July 17, 2022 02:47
@Depal1 Depal1 linked an issue Jul 17, 2022 that may be closed by this pull request
@lixin9311
Copy link
Contributor

I think you can try to use https://github.com/PlayCover/PlayCover/releases.atom
Just a suggestion.

@Candygoblen123
Copy link
Member Author

After done discussion on discord, i've decided to go ahead and implement Sparkle Framework as our updater, and the releases.atom file isn't in the correct format for Sparkle I'm afraid.

@Candygoblen123 Candygoblen123 marked this pull request as ready for review July 20, 2022 02:25
@Candygoblen123 Candygoblen123 changed the title Improve Updater feat: Implement Sparkle Updater Jul 20, 2022
@Candygoblen123
Copy link
Member Author

I believe that this is ready to be reviewed. Feel free to contact me here or on discord so that we can discuss the additional signing requirements that Sparkle requires, and potentially automating the publishing update process in an action.

@Depal1 Depal1 added the enhancement New feature or request label Jul 20, 2022
… develop

# Conflicts:
#	PlayCover/Services/UpdateService.swift
#	PlayCover/View/MainView.swift
#	PlayCover/View/MenuBarView.swift
#	PlayCover/View/PlayCoverApp.swift
@Depal1 Depal1 merged commit 199cb0e into PlayCover:develop Jul 29, 2022
@Depal1 Depal1 mentioned this pull request Aug 10, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Search update feature issues
3 participants