Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Set Application Category Type #1087

Merged

Conversation

TheMoonThatRises
Copy link
Member

@TheMoonThatRises TheMoonThatRises commented Sep 8, 2023

This allows the user to set the category of the app by adding the key LSApplicationCategoryType to the Info.plist located in the application. This can be changed under Misc in the application's settings.

More specifically, this feature enables and closes #1085 "Game Mode", which can be accomplished by the user setting the application type to public.app-category.games for those on MacOS Sonoma.

This change is tested on MacOS Sonoma Developer Beta 23A5337a. This should not affect the changes, but should still be tested on a stable version of MacOS.

Other Notes for reviewers:

  • Should LSApplicationCategoryType be localised? Currently, the code is implemented but was too time consuming to implement it in the localisation files.
  • Should the installer popup be updated to a sheet or something similar to accommodate for the user to specify the application category type on installation? The setting has been implemented to set all the installing types to the specified value but per installation type setting would be require some major refactoring.
  • Should the application inherent the application type from the IPA? Since the application's Info.plist does not initially have the key LSApplicationCategoryType, it would have to be located elsewhere as iOS apps still have the application category types. I will look into that but since it is not already implemented, I am not too sure it will work.

@zanderp25 zanderp25 added the enhancement New feature or request label Sep 9, 2023
@JoseMoreville
Copy link
Member

Should LSApplicationCategoryType be localised? Currently, the code is implemented but was too time consuming to implement it in the localisation files.

Just add it to the english loc file

Should the installer popup be updated to a sheet or something similar to accommodate for the user to specify the application category type on installation? The setting has been implemented to set all the installing types to the specified value but per installation type setting would be require some major refactoring

This can be discussed later, as you said, it'll require a major refactor of installer code

Should the application inherent the application type from the IPA? Since the application's Info.plist does not initially have the key LSApplicationCategoryType, it would have to be located elsewhere as iOS apps still have the application category types. I will look into that but since it is not already implemented, I am not too sure it will work.

This is worth to take a look since it should be provided with the app plist but we can implement it as nil meanwhile

@JoseMoreville JoseMoreville merged commit 413fb15 into PlayCover:develop Sep 25, 2023
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

[Feature]: Game Mode support
3 participants