Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix MetalHUD not showing when launching app from alias #1088

Merged
merged 1 commit into from Sep 25, 2023
Merged

Fix MetalHUD not showing when launching app from alias #1088

merged 1 commit into from Sep 25, 2023

Conversation

TheMoonThatRises
Copy link
Member

@TheMoonThatRises TheMoonThatRises commented Sep 8, 2023 •
edited

Fixes #961. Writes to the defaults key MetalForceHudEnabled instead of saving as an environment variable.

Thoughts for reviewer:

  • Should MetalHud be removed from the settings file and have it directly linked to defaults (similar to PlayTools checking if it is installed in the binary instead of keeping track via the settings file)?
  • Should this be merged into Fix environment variables when launching via alias #1090, with it being stored in the Info.plist instead of defaults?

@TheMoonThatRises TheMoonThatRises changed the title Fix MetalHUD not showing when launching app outside of PlayCover Fix MetalHUD not showing when launching app from alias Sep 8, 2023
@TheMoonThatRises TheMoonThatRises marked this pull request as draft September 9, 2023 01:34
@TheMoonThatRises TheMoonThatRises mentioned this pull request Sep 9, 2023
Merged
@TheMoonThatRises TheMoonThatRises marked this pull request as ready for review September 9, 2023 05:59
@JoseMoreville JoseMoreville merged commit 9d8beb2 into PlayCover:develop Sep 25, 2023
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@JoseMoreville JoseMoreville JoseMoreville approved these changes

Assignees
No one assigned
Labels
None yet
Projects
3.0.0
Status: Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[Bug]: Metal HUD does not show if game is opened from Launchpad
2 participants
@TheMoonThatRises @JoseMoreville