(related to #86) Updating string keys for AppView.swift #121
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Revamped the entire localizations with up-to-date sentences written with the current situation in mind
Lots of old translations no longer apply, and it is a good idea to get people to translate for the app again according to the current situation now that the base localization (English) is accurate and up-to-date
Fixed some issues with the locale files
ignore this 💀
# Conflicts: # PlayCover/ViewModel/Log.swift # PlayCover/de.lproj/Localizable.strings # PlayCover/en.lproj/Localizable.strings # PlayCover/es.lproj/Localizable.strings # PlayCover/fr.lproj/Localizable.strings # PlayCover/id.lproj/Localizable.strings # PlayCover/it.lproj/Localizable.strings # PlayCover/ja.lproj/Localizable.strings # PlayCover/ko.lproj/Localizable.strings # PlayCover/ru.lproj/Localizable.strings # PlayCover/vi.lproj/Localizable.strings # PlayCover/zh-Hans.lproj/Localizable.strings
# Conflicts: # PlayCover/View/AppSettingsView.swift
# Conflicts: # PlayCover/View/AppSettingsView.swift # PlayCover/ViewModel/Log.swift
# Conflicts: # PlayCover/View/AppsView.swift
Reverted button style, brought back "soundAlert.*"
… feature/revamped-string-keys
Adjusted minimum window size for fitting to 4 columns of apps just right, fixed a typo that exposed raw string key, and added some horizontal paddings to search bar for better aesthetics Modded various UI aspect of things used same style as every other buttons in UI for consistency Trimmed paddings on bottom bar Adjusted padding for even paddings around buttons (because there is an un-removable safe area padding at the bottom of the window (which i cant seem to nuke by "ignoreSafeArea()") ) Added a thin border to search bar for aesthetic purposes and ease of use by creating that contrast between search bar and background
:chef_kiss: Updated my Chinese locale updated to the new formatting used
Added spacings to separate different types of messages and changed some keys for consistency Tuned ".ipa" parts for consistency Updated text in setup view
moved crash button to the left of "Experiencing issues?" button to save some space and avoid taking up unnecessary row of space just for the 1 button
SwiftUI is all we need ✨
… feature/revamped-string-keys
According to Isaac's comments
# Conflicts: # PlayCover/View/MainView.swift
…d-Explorer/PlayCover-1 into feature/revamped-string-keys
… feature/revamped-string-keys # Conflicts: # PlayCover/View/AppSettingsView.swift # PlayCover/View/PlayAppView.swift
Added and mapped keys to strings Updated more UI to work with locale Reverted signing settings Reverted changes Updated locale
… feature/revamped-string-keys
mainly the bottom two buttons in swttings view
Updated locale to work with latest PR
mainly the bottom two buttons in swttings view
…d-Explorer/PlayCover-1 into feature/revamped-string-keys
… feature/revamped-string-keys # Conflicts: # PlayCover/View/AppsView.swift
This reverts commit de00985. Reverted ignore settings
Added corner radius
… feature/revamped-string-keys # Conflicts: # PlayCover/View/ChangeGenshinAccountView.swift # PlayCover/View/DeleteGenshinStoredAccountView.swift # PlayCover/View/PlayAppView.swift # PlayCover/View/StoreGenshinAccountView.swift
Fixed some changes
This reverts commit 686d1a7.
# Conflicts: # PlayCover/View/AppSettingsView.swift
SetupView.swift
Depal1
approved these changes
Jul 31, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I am certain that I have updated the file in #86 before but maybe the changes are lost during rebase or resolving conflicts. This PR brings back the lost changes.