Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feature: ✨ Now you can switch between Ipad models on app settings. #150

Merged
merged 1 commit into from Aug 12, 2022

Conversation

JoseMoreville
Copy link
Member

Like the title says, this PR aims to add a picker on app settings to let the user select an ipad pro model to run the app on.
The models I added are Ipad pro 1st, 3rd and 5th gen. I plan to add iphone later but I still have to think in a way to avoid problems with this.

This PR needs PlayCover/PlayTools#13 to work

@JoseMoreville JoseMoreville marked this pull request as ready for review August 12, 2022 01:51
@JoseMoreville
Copy link
Member Author

Please, do not merge it until there's a new version of playtools

@Depal1
Copy link
Member

Depal1 commented Aug 12, 2022

I would recommend adding more detailed information on the models in question, if not on this PR, on a future one (particularly as a dropdown menu). This need arises since not all first generation iPad Pro models share the same onboard memory specifications.

The models in use and their data are left for future reference.
iPad6,7 - iPad Pro (12.9-inch) (1st generation) - A9X - 4Gb
iPad8,6 - iPad Pro (12.9-inch) (3rd generation) - A12Z - 4Gb (6Gb?)*
iPad13,8 - iPad Pro (12.9-inch) (5th generation) - M1 - 8Gb (16Gb?)*

*These models come with more memory on high storage configurations. Since they both share the same model identifier, it is unbeknownst to me if these higher end configurations are in use on PlayCover, or the former ones are.

@ohaiibuzzle
Copy link
Member

I wonder if it is possible to have a few iPad presets, then an option to input your own Model and Motherboard Identifier. Looking at the changes made to PlayTools, this may takes a bit more logic changes, but would effectively future proof this feature (in case someone wants to go back to an earlier version of PC)

@Depal1 Depal1 linked an issue Aug 12, 2022 that may be closed by this pull request
@JoseMoreville
Copy link
Member Author

I wonder if it is possible to have a few iPad presets, then an option to input your own Model and Motherboard Identifier. Looking at the changes made to PlayTools, this may takes a bit more logic changes, but would effectively future proof this feature (in case someone wants to go back to an earlier version of PC)

This will be done in a future, not sure when i'm going to start working on it but its planned as said on discrod

@JoseMoreville JoseMoreville merged commit 48437c1 into PlayCover:develop Aug 12, 2022
@lixin9311 lixin9311 added the enhancement New feature or request label Aug 17, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Support for changing the amount of RAM used
4 participants