Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

TikTok Blacklisting and uninstall function. #450

Closed
wants to merge 13 commits into from
Closed

TikTok Blacklisting and uninstall function. #450

wants to merge 13 commits into from

Conversation

Amachik
Copy link
Contributor

@Amachik Amachik commented Oct 26, 2022

simple solution. should work ok.

@Candygoblen123
Copy link
Member

Can you fix the swiftLint errors?

PlayCover/en.lproj/Localizable.strings Outdated Show resolved Hide resolved
@Depal1
Copy link
Member

Depal1 commented Oct 26, 2022

This PR is reverting changes from #449. Please rebase.

@Depal1 Depal1 marked this pull request as draft October 26, 2022 18:00
@Depal1 Depal1 added the squash Indicates whether a PR must be squashed before being merged label Oct 26, 2022
@ZhichGaming
Copy link
Contributor

ZhichGaming commented Oct 26, 2022

It would be better if you made an alert pop up that only has the option to uninstall instead of just uninstalling as soon as it is launched. The user would be able to either force quit the app or proceed with the uninstall. This way, the user would have less risk of losing data and they wouldn’t panic as much.

@Amachik
Copy link
Contributor Author

Amachik commented Oct 26, 2022

i will do a rewrite of this.

moons solution is the best i would say

@Amachik
Copy link
Contributor Author

Amachik commented Oct 26, 2022

It would be better if you made an alert pop up that only has the option to uninstall instead of just uninstalling as soon as it is launched. The user would be able to either force quit the app or proceed with the uninstall. This way, the user would have less risk of losing data and they wouldn’t panic as much.

also there will be no data cuz the app will not even open.

@TheMoonThatRises
Copy link
Member

also there will be no data cuz the app will not even open.

This is more for users who upgraded and have already used the app before it was tagged as malicious.

@ZhichGaming
Copy link
Contributor

Ah, that’s true I guess. But maybe the user wants to bypass it, ignoring the warning by opening through finder. We wouldn’t want them accidentally deleting their data if they opened it accidentally through playcover.

@Amachik
Copy link
Contributor Author

Amachik commented Oct 26, 2022

Ah, that’s true I guess. But maybe the user wants to bypass it, ignoring the warning by opening through finder. We wouldn’t want them accidentally deleting their data if they opened it accidentally through playcover.

if user is messing with files bcs he wants to bypass it, thats not really ur problem. he is on his own. he can use sideloadly.

@Amachik Amachik marked this pull request as ready for review October 29, 2022 15:39
@Amachik Amachik closed this Nov 1, 2022
@Amachik Amachik reopened this Nov 1, 2022
@Amachik
Copy link
Contributor Author

Amachik commented Nov 1, 2022

All
should be fixed.

@@ -78,14 +76,14 @@ struct StoreAppView: View {
.appendingPathExtension("ipa")
try FileManager.default.moveItem(at: url, to: tmpDir)
uif.ipaUrl = tmpDir
DispatchQueue.main.async {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is still reverting the changes done in #449.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

wtf i did clean fork :D i feel like an idiot rn .

@Amachik
Copy link
Contributor Author

Amachik commented Nov 1, 2022

i need to close this. no other way to fix this issue.

@Amachik Amachik closed this Nov 1, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
squash Indicates whether a PR must be squashed before being merged
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants