-
Notifications
You must be signed in to change notification settings - Fork 728
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
TikTok Blacklisting and uninstall function. #450
Conversation
Can you fix the swiftLint errors? |
This PR is reverting changes from #449. Please rebase. |
It would be better if you made an alert pop up that only has the option to uninstall instead of just uninstalling as soon as it is launched. The user would be able to either force quit the app or proceed with the uninstall. This way, the user would have less risk of losing data and they wouldn’t panic as much. |
i will do a rewrite of this. moons solution is the best i would say |
also there will be no data cuz the app will not even open. |
This is more for users who upgraded and have already used the app before it was tagged as malicious. |
Ah, that’s true I guess. But maybe the user wants to bypass it, ignoring the warning by opening through finder. We wouldn’t want them accidentally deleting their data if they opened it accidentally through playcover. |
if user is messing with files bcs he wants to bypass it, thats not really ur problem. he is on his own. he can use sideloadly. |
All |
@@ -78,14 +76,14 @@ struct StoreAppView: View { | |||
.appendingPathExtension("ipa") | |||
try FileManager.default.moveItem(at: url, to: tmpDir) | |||
uif.ipaUrl = tmpDir | |||
DispatchQueue.main.async { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is still reverting the changes done in #449.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
wtf i did clean fork :D i feel like an idiot rn .
i need to close this. no other way to fix this issue. |
simple solution. should work ok.